From: "Shawn O. Pearce" <spearce@spearce.org>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] run-command: Redirect stderr to a pipe before redirecting stdout to stderr
Date: Thu, 6 Mar 2008 01:42:25 -0500 [thread overview]
Message-ID: <20080306064225.GS8410@spearce.org> (raw)
In-Reply-To: <20080306064415.c5ca762a.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> wrote:
> On Wed, 5 Mar 2008, I wrote:
> > With this patch, in the 'start_command' function after forking
> > we now take care of stderr in the child process before stdout.
> > ...
>
> I am afraid I forgot the
>
> From: "Shawn O. Pearce" <spearce@spearce.org>
>
> at the top of the patch in my last resend, so the patch was attributed to me instead of Shawn.
>
> Is it possible to do something about it ? (I fear not since it is now in 'next' but maybe I am wrong.)
Nope, its done and over with.
Don't sweat it. It was a very short patch, you wrote it apparently
independently from me, so the author line from you is just as valid.
I say its fine as is. Maybe better. Your version had an API
doc update. My version is what triggered the "maybe we should
document the API before we modify it further" discussion. ;-)
--
Shawn.
next prev parent reply other threads:[~2008-03-06 6:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 7:35 [PATCH] run-command: Redirect stderr to a pipe before redirecting stdout to stderr Christian Couder
2008-03-05 7:36 ` Johannes Sixt
2008-03-06 1:00 ` Xavier Maillard
2008-03-06 5:44 ` Christian Couder
2008-03-06 6:42 ` Shawn O. Pearce [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-03-03 19:06 Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306064225.GS8410@spearce.org \
--to=spearce@spearce.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.