From: Ingo Molnar <mingo@elte.hu>
To: Glauber Costa <glommer@gmail.com>
Cc: Glauber Costa <gcosta@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
tglx@linutronix.de
Subject: Re: [PATCH 1/1] export native versions of machine_ops functions
Date: Thu, 6 Mar 2008 13:13:13 +0100 [thread overview]
Message-ID: <20080306121313.GA19613@elte.hu> (raw)
In-Reply-To: <5d6222a80803060349g69f570f3j9eaab980d7c58da@mail.gmail.com>
* Glauber Costa <glommer@gmail.com> wrote:
> > i'd like to do this only if there are actual users - otherwise
> > we'll get a trickle of "make needlessly global functions static"
> > patches a few weeks later ;-)
>
> KVM is a user for that. Because it registers a memory area in which
> the host will be continually writting to (the clock), when it
> shutdown, the host have no way to know it has to stop. If you're
> really shutting down, there's no problem. But if you're kexecing, for
> example, the host will keep writting to a random memory area after the
> new kernel installs.
i mean, i agree in general - but KVM is not a user of any of those
currently static functions. So i've applied your patch but lets make
sure those functions really get used :)
Ingo
next prev parent reply other threads:[~2008-03-06 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 17:44 [PATCH 1/1] export native versions of machine_ops functions Glauber Costa
2008-03-06 10:55 ` Ingo Molnar
2008-03-06 11:49 ` Glauber Costa
2008-03-06 12:13 ` Ingo Molnar [this message]
2008-03-06 12:15 ` Avi Kivity
2008-03-06 12:28 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306121313.GA19613@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=glommer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.