From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/2] VFS: Factor out part of vfs_setxattr so it can be called from the SELinux hook for inode_setsecctx. Date: Thu, 6 Mar 2008 13:27:03 +0100 Message-ID: <20080306122703.GA4648@lst.de> References: <1204743288-3461-1-git-send-email-dpquigl@tycho.nsa.gov> <1204743288-3461-2-git-send-email-dpquigl@tycho.nsa.gov> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: casey@schaufler-ca.com, chrisw@sous-sol.org, sds@tycho.nsa.gov, jmorris@namei.org, hch@lst.de, viro@zeniv.linux.org.uk, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org To: "David P. Quigley" Return-path: Content-Disposition: inline In-Reply-To: <1204743288-3461-2-git-send-email-dpquigl@tycho.nsa.gov> Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Mar 05, 2008 at 01:54:47PM -0500, David P. Quigley wrote: > This factors out the part of the vfs_setxattr function that performs the > setting of the xattr and its notification. This is needed so the SELinux > implementation of inode_setsecctx can handle the setting of it's xattr while > maintaining the proper separation of layers. Looks good, but I'm not entirely sure do_setxattr is a good name for this exported functionality. __vfs_setxattr_noperm might be better. Please also add a kerneldoc comment for each new global function.