From: Paul Jackson <pj@sgi.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, clameter@sgi.com,
Lee.Schermerhorn@hp.com, ak@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [patch -mm 4/4] mempolicy: remove includes for duplicate headers
Date: Thu, 6 Mar 2008 14:19:23 -0600 [thread overview]
Message-ID: <20080306141923.45ce4214.pj@sgi.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0803061136320.18590@chino.kir.corp.google.com>
David R wrote:
> Remove #includes for:
>
> linux/mempolicy.h (already from linux/migrate.h)
> linux/mm.h (already from linux/highmem.h)
I didn't see any problem offhand with the other patches 0 to 3 in this
set, but this patch 4/4 surprises me.
Perhaps I'm out of phase with what's customary in the kernel, but I
prefer directly including whatever headers I explicitly need.
Depending on some other header to drag in something you have explicit
need of anyway makes things more fragile.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
next prev parent reply other threads:[~2008-03-06 20:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 20:05 [patch -mm 1/4] mempolicy: move rebind functions David Rientjes
2008-03-06 20:05 ` [patch -mm 2/4] mempolicy: create mempolicy_operations structure David Rientjes
2008-03-06 20:05 ` [patch -mm 3/4] mempolicy: small header file cleanup David Rientjes
2008-03-06 20:05 ` [patch -mm 4/4] mempolicy: remove includes for duplicate headers David Rientjes
2008-03-06 20:19 ` Paul Jackson [this message]
2008-03-06 20:51 ` David Rientjes
2008-03-06 21:01 ` Paul Jackson
2008-03-07 8:45 ` Andrew Morton
2008-03-07 20:44 ` Regression: Re: [patch -mm 2/4] mempolicy: create mempolicy_operations structure Lee Schermerhorn
2008-03-07 20:44 ` Lee Schermerhorn
2008-03-07 21:48 ` David Rientjes
2008-03-07 21:48 ` David Rientjes
2008-03-07 21:57 ` Paul Jackson
2008-03-07 21:57 ` Paul Jackson
2008-03-08 18:49 ` Lee Schermerhorn
2008-03-08 18:49 ` Lee Schermerhorn
2008-03-08 22:09 ` David Rientjes
2008-03-08 22:09 ` David Rientjes
2008-03-10 14:58 ` Lee Schermerhorn
2008-03-10 14:58 ` Lee Schermerhorn
2008-03-12 19:33 ` [PATCH] Mempolicy: fix parsing of tmpfs mpol mount option Lee Schermerhorn
2008-03-12 19:33 ` Lee Schermerhorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306141923.45ce4214.pj@sgi.com \
--to=pj@sgi.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.