From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ron Rindjunsky <ron.rindjunsky@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
tomas.winkler@intel.com
Subject: Re: [RFC] mac80211: handling Qdisc issues
Date: Thu, 6 Mar 2008 18:30:31 +0100 [thread overview]
Message-ID: <200803061830.32316.mb@bu3sch.de> (raw)
In-Reply-To: <1204824008.25502.123.camel@johannes.berg>
On Thursday 06 March 2008 18:20:08 Johannes Berg wrote:
>
> > > /* Decide by priority where to put this frame. */
> > > - ring = priority_to_txring(dev, ctl->queue);
> > > +#ifdef CONFIG_NETDEVICES_MULTIQUEUE
> > > + ring = priority_to_txring(dev, skb->queue_mapping);
> > > +#else
> > > + /* XXX: b43 qos needs a lot of work */
> > > + ring = 1;
> > > +#endif
> > > }
> >
> > ehm, this won't compile.
> > And did you see the patches I recently submitted?
>
> That's my old patch, I think Ron doesn't know anything about b43 :) And
> my patch was based before your QoS support patches.
Ah ok. You can just add this #ifdef to the already existing
dynamic condition on b43_modparam_qos in the new queue mapping function.
--
Greetings Michael.
next prev parent reply other threads:[~2008-03-06 17:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 16:51 [RFC] mac80211: handling Qdisc issues Ron Rindjunsky
2008-03-06 17:15 ` Michael Buesch
2008-03-06 17:20 ` Johannes Berg
2008-03-06 17:30 ` Michael Buesch [this message]
2008-03-06 17:42 ` Johannes Berg
2008-03-06 18:21 ` Michael Buesch
2008-03-06 18:02 ` Ivo van Doorn
2008-03-06 18:06 ` Johannes Berg
2008-03-06 18:27 ` Ivo van Doorn
2008-03-06 18:47 ` Johannes Berg
2008-03-09 11:43 ` Ron Rindjunsky
2008-03-09 20:33 ` Johannes Berg
2008-03-11 16:54 ` Luis R. Rodriguez
2008-03-23 9:26 ` Ron Rindjunsky
2008-03-23 12:10 ` Johannes Berg
2008-03-25 13:00 ` Johannes Berg
[not found] ` <1879838866982C46A9CB3D56BA49ADEB04B41299@hasmsx411.ger.corp.intel.com>
[not found] ` <1206623412.22530.46.camel@johannes.berg>
[not found] ` <1879838866982C46A9CB3D56BA49ADEB04B42158@hasmsx411.ger.corp.intel.com>
[not found] ` <1208426282.4066.3.camel@johannes.berg>
[not found] ` <1879838866982C46A9CB3D56BA49ADEB04CCE9C4@hasmsx411.ger.corp.intel.com>
[not found] ` <C07C4589BE74A34981C3C3525EE1F80103BAF061@hasmsx412.ger.corp.intel.com>
[not found] ` <1208469393.4066.92.camel@johannes.berg>
[not found] ` <C07C4589BE74A34981C3C3525EE1F80103BF5D59@hasmsx412.ger.corp.intel.com>
[not found] ` <1209027037.3357.39.camel@johannes.berg>
[not found] ` <1879838866982C46A9CB3D56BA49ADEB04D09D98@hasmsx411.ger.corp.intel.com>
2008-04-26 16:02 ` Johannes Berg
2008-04-27 8:10 ` Ron Rindjunsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803061830.32316.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ron.rindjunsky@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.