From: Andi Kleen <andi@firstfloor.org>
To: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, axboe@kernel.dk
Subject: [PATCH] [21/21] Convert DMA buffers in ch.c to allocate via the block layer
Date: Thu, 6 Mar 2008 21:51:43 +0100 (CET) [thread overview]
Message-ID: <20080306205143.771491B419C@basil.firstfloor.org> (raw)
In-Reply-To: <20080306951.147874949@firstfloor.org>
Instead of specifying GFP_DMA always ask the block layer to get
some dma'able memory
Signed-off-by: Andi Kleen <ak@suse.de>
---
drivers/scsi/ch.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
Index: linux/drivers/scsi/ch.c
===================================================================
--- linux.orig/drivers/scsi/ch.c
+++ linux/drivers/scsi/ch.c
@@ -231,7 +231,7 @@ ch_read_element_status(scsi_changer *ch,
u_char *buffer;
int result;
- buffer = kmalloc(512, GFP_KERNEL | GFP_DMA);
+ buffer = blk_kmalloc(ch->device->request_queue, 512, GFP_KERNEL);
if(!buffer)
return -ENOMEM;
@@ -261,7 +261,7 @@ ch_read_element_status(scsi_changer *ch,
}
dprintk("READ ELEMENT STATUS for element 0x%x failed\n",elem);
}
- kfree(buffer);
+ blk_kfree(buffer, 512);
return result;
}
@@ -288,9 +288,10 @@ ch_readconfig(scsi_changer *ch)
int result,id,lun,i;
u_int elem;
- buffer = kzalloc(512, GFP_KERNEL | GFP_DMA);
+ buffer = blk_kmalloc(ch->device->request_queue, 512, GFP_KERNEL);
if (!buffer)
return -ENOMEM;
+ memset(buffer, 0, 512);
memset(cmd,0,sizeof(cmd));
cmd[0] = MODE_SENSE;
@@ -401,7 +402,7 @@ ch_readconfig(scsi_changer *ch)
}
}
ch->voltags = 1;
- kfree(buffer);
+ blk_kfree(buffer, 512);
return 0;
}
@@ -733,7 +734,7 @@ static long ch_ioctl(struct file *file,
return -EINVAL;
elem = ch->firsts[cge.cge_type] + cge.cge_unit;
- buffer = kmalloc(512, GFP_KERNEL | GFP_DMA);
+ buffer = blk_kmalloc(ch->device->request_queue, 512, GFP_KERNEL);
if (!buffer)
return -ENOMEM;
mutex_lock(&ch->lock);
@@ -786,7 +787,7 @@ static long ch_ioctl(struct file *file,
vprintk("device has no volume tag support\n");
goto voltag_retry;
}
- kfree(buffer);
+ blk_kfree(buffer, 512);
mutex_unlock(&ch->lock);
if (copy_to_user(argp, &cge, sizeof (cge)))
next prev parent reply other threads:[~2008-03-06 20:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 20:51 [PATCH] [0/21] Remove isa_unchecked_dma and some more GFP_DMAs in the mid layer v2 Andi Kleen
2008-03-06 20:51 ` [PATCH] [1/21] Add new sense_buffer_mask host template field Andi Kleen
2008-03-06 20:51 ` [PATCH] [2/21] Remove unchecked_isa in BusLogic Andi Kleen
2008-03-06 20:51 ` [PATCH] [3/21] Remove unchecked_isa_dma in advansys.c Andi Kleen
2008-03-06 21:04 ` Matthew Wilcox
2008-03-06 22:04 ` Andi Kleen
2008-03-07 0:59 ` Matthew Wilcox
2008-03-07 1:09 ` Andi Kleen
2008-03-06 20:51 ` [PATCH] [4/21] Remove unchecked_isa_dma in gdth Andi Kleen
2008-03-06 20:51 ` [PATCH] [5/21] Remove unchecked_isa_dma in eata.c Andi Kleen
2008-03-06 20:51 ` [PATCH] [6/21] Remove unchecked_isa_dma in aha1542 Andi Kleen
2008-03-06 20:51 ` [PATCH] [7/21] Remove unchecked_isa_dma in aha152x/wd7000/sym53c416/u14-34f/NCR53c406a Andi Kleen
2008-03-06 20:51 ` [PATCH] [8/21] Remove random noop unchecked_isa_dma users Andi Kleen
2008-03-06 20:51 ` [PATCH] [9/21] Add blk_kmalloc/blk_alloc_pages Andi Kleen
2008-03-06 20:51 ` [PATCH] [11/21] Remove unchecked_isa_dma support for hostdata Andi Kleen
2008-03-06 20:51 ` [PATCH] [12/21] Remove unchecked_isa_dma checks in sg.c Andi Kleen
2008-03-06 20:51 ` [PATCH] [13/21] Use blk_kmalloc in scsi_scan Andi Kleen
2008-03-06 20:51 ` [PATCH] [14/21] Don't disable direct_io for unchecked_isa_dma in st.c Andi Kleen
2008-03-06 20:51 ` [PATCH] [15/21] Remove automatic block layer bouncing for unchecked_isa_dma Andi Kleen
2008-03-06 20:51 ` [PATCH] [16/21] Convert sr driver over the blk_kmalloc Andi Kleen
2008-03-06 20:51 ` [PATCH] [17/21] Remove unchecked_isa_dma from sysfs Andi Kleen
2008-03-06 20:51 ` [PATCH] [18/21] Switch to a single SCSI command pool Andi Kleen
2008-03-06 20:51 ` [PATCH] [19/21] Finally remove unchecked_isa_dma support for Cmnds Andi Kleen
2008-03-06 20:51 ` [PATCH] [20/21] Finally kill unchecked_isa_dma Andi Kleen
2008-03-06 20:51 ` Andi Kleen [this message]
2008-03-06 22:13 ` [PATCH] [0/21] Remove isa_unchecked_dma and some more GFP_DMAs in the mid layer v2 James Bottomley
2008-03-06 22:19 ` Andi Kleen
2008-03-06 22:23 ` [PATCH] [0/21] Remove isa_unchecked_dma and some more GFP_DMAs in the mid layer v2 II Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2008-11-15 23:11 [PATCH] [0/21] Remove isa_unchecked_dma and some more GFP_DMAs in the mid layer v5 Andi Kleen
2008-11-15 23:11 ` [PATCH] [21/21] Convert DMA buffers in ch.c to allocate via the block layer Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306205143.771491B419C@basil.firstfloor.org \
--to=andi@firstfloor.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.