From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sebastian Siewior <al+sa@ml.breakpoint.cc>
Cc: alsa-devel@alsa-project.org, Nicolas Pitre <nico@cam.org>,
William Pitcock <nenolod@sacredspiral.co.uk>
Subject: Re: [RFC] add a "private" field to the ac97 struct
Date: Thu, 6 Mar 2008 20:53:09 +0000 [thread overview]
Message-ID: <20080306205309.GB3993@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20080306172225.GA8492@Chamillionaire.breakpoint.cc>
On Thu, Mar 06, 2008 at 06:22:25PM +0100, Sebastian Siewior wrote:
> The problem is more or less that I can't pass the value to the other
> probe function and the global variable doesn't look all that pretty. Am
> I missing something here?
This is also a problem for the wm97xx touchscreen drivers. They have a
similar issue with wanting to get platform configuration into a device
probed off the AC97 bus with the additional issue that features like
syncing with screen redraw will often require code to interface with
other hardware in the system. If something is added to the AC97 data
it'd be helpful if it were a void * so the wm97xx touch driver could use
it to pass a struct with more data.
This is not really an AC97-specific issue - any device discoverd via a
bus is going to have a similar thing if it needs to obtain platform
data. I don't know how OpenFirmware normally handles these things?
It's going to be an issue for other buses like PCI too in many systems,
MAC addresses for NICs being the example I've run into myself in a
previous life.
In the case of the wm97xx touchscreen we've avoided the problem by
having the touch driver register platform devices; this isn't ideal but
works well in the systems which are the typical targets for these
devices. I had been intending to revisit this issue at some point but
it's quite a way down my TODO list.
The wm97xx drivers touch aren't in mainline yet - if you want to have a
look the most current upstream submission versions can be found in the
upstream branch of:
git://opensource.wolfsonmicro.com/linux-2.6-touch
gitweb:
http://opensource.wolfsonmicro.com/cgi-bin/gitweb.cgi?p=linux-2.6-touch.git;a=summary
prev parent reply other threads:[~2008-03-06 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 16:42 [RFC] add a "private" field to the ac97 struct Sebastian Siewior
2008-03-06 17:12 ` William Pitcock
2008-03-06 17:22 ` Sebastian Siewior
2008-03-06 20:53 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306205309.GB3993@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=al+sa@ml.breakpoint.cc \
--cc=alsa-devel@alsa-project.org \
--cc=nenolod@sacredspiral.co.uk \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.