All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: [PATCH3] Don't optimize function calls with -g
Date: Fri, 7 Mar 2008 14:58:18 +0000	[thread overview]
Message-ID: <20080307145818.GA5627@implementation.uk.xensource.com> (raw)
In-Reply-To: <C3F6F55F.1DAE8%keir.fraser@eu.citrix.com>

Keir Fraser, le Fri 07 Mar 2008 13:36:31 +0000, a écrit :
> Note that we do CFLAGS ?= ... in StdGNU.mk and SunOS.mk right
> now. Probably these should be changed to +=.

Ooh, that's why I missed the already existing -fno-omit-frame-pointer
there.

> Whether SunOS should really have different usage of omit-frame-pointer is
> open to argument.

Ok, I'll leave it to people who actually run a SunOS system :)



Don't optimize function calls on GNU systems with debug=y
by enforcing the addition of -fno-omit-frame-pointer, and adding
-fno-optimize-sibling-calls.

Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>

diff -r fb74347d80c3 config/StdGNU.mk
--- a/config/StdGNU.mk	Wed Mar 05 12:20:40 2008 +0000
+++ b/config/StdGNU.mk	Fri Mar 07 14:54:43 2008 +0000
@@ -45,5 +45,5 @@ CFLAGS ?= -O2 -fomit-frame-pointer
 CFLAGS ?= -O2 -fomit-frame-pointer
 else
 # Less than -O1 produces bad code and large stack frames
-CFLAGS ?= -O1 -fno-omit-frame-pointer
+CFLAGS += -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls
 endif

      parent reply	other threads:[~2008-03-07 14:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 15:55 [PATCH] Use -fno-omit-frame-pointer in addition to -g Samuel Thibault
2008-03-06 16:01 ` [PATCH2] Don't optimize function calls with -g Samuel Thibault
2008-03-07 13:36   ` Keir Fraser
2008-03-07 14:21     ` Samuel Thibault
2008-03-07 14:58     ` Samuel Thibault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080307145818.GA5627@implementation.uk.xensource.com \
    --to=samuel.thibault@eu.citrix.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.