From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH] i2c: Keep client->driver and client->dev.driver in sync Date: Sat, 8 Mar 2008 13:12:36 -0800 Message-ID: <200803081312.36524.david-b@pacbell.net> References: <20080308214911.5344eba9@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080308214911.5344eba9-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org Errors-To: i2c-bounces-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org To: Jean Delvare Cc: Linux I2C List-Id: linux-i2c@vger.kernel.org On Saturday 08 March 2008, Jean Delvare wrote: > From: Hans Verkuil > > Ensures that client->driver is set to NULL if the probe() returns an > error (this keeps client->driver and client->dev.driver in sync). > > Signed-off-by: Hans Verkuil > Signed-off-by: Jean Delvare > --- > Hans, I've updated your patch a bit to make i2c_device_probe() look > more like i2c_device_remove(); hope you don't mind. > > David, this fix looks correct to me, I'll send it to Linus quickly if > you have no objection. The only issue I have is that code which the driver probe() calls may expect client->driver to be set, but it won't be... While I'd rather see client->driver vanish, in this case I'd just suggest leaving the early assignment, and nulling it out on error (instead of assigning it on success). > drivers/i2c/i2c-core.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > --- linux-2.6.25-rc4.orig/drivers/i2c/i2c-core.c 2008-03-08 17:57:52.000000000 +0100 > +++ linux-2.6.25-rc4/drivers/i2c/i2c-core.c 2008-03-08 21:43:11.000000000 +0100 > @@ -90,12 +90,15 @@ static int i2c_device_probe(struct devic > { > struct i2c_client *client = to_i2c_client(dev); > struct i2c_driver *driver = to_i2c_driver(dev->driver); > + int status; > > if (!driver->probe) > return -ENODEV; > - client->driver = driver; > dev_dbg(dev, "probe\n"); > - return driver->probe(client); > + status = driver->probe(client); > + if (status == 0) > + client->driver = driver; > + return status; > } > > static int i2c_device_remove(struct device *dev) > > > -- > Jean Delvare > _______________________________________________ i2c mailing list i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org http://lists.lm-sensors.org/mailman/listinfo/i2c