From: Christoph Hellwig <hch@infradead.org>
To: Duane Griffin <duaneg@dghda.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andreas Dilger <adilger@sun.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Theodore Tso <tytso@mit.edu>,
sct@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] jbd2: replace potentially false assertion with if block
Date: Sat, 8 Mar 2008 13:45:43 -0500 [thread overview]
Message-ID: <20080308184543.GA4284@infradead.org> (raw)
In-Reply-To: <e9e943910803081037w5e7a8743p449b999001b94281@mail.gmail.com>
On Sat, Mar 08, 2008 at 06:37:08PM +0000, Duane Griffin wrote:
> Sorry if I'm missing something here, but I think the caches do need to
> be checked. If jbd/ext3 are not modular then even if initialisation
> fails the journal code may still be called later. I noticed this when
> testing the failure modes after making my original fix.
Doh, I think you're right. Just because jbd initialization fails
ext3 could succeed later on. We probably want to make ext3
initialization fail early in that case through an exported flag.
> I've modified my changes to match the way you suggested doing things
> in your earlier reply (and thanks for the review, BTW). If you would
> prefer I'll rework my changes as a separate patch on top. Just let me
> know.
I don't really care how it's delivered. Just consider my patches a
scetch and do whatever you think is best with them.
next prev parent reply other threads:[~2008-03-08 18:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 1:31 [PATCH 1/3] jbd2: eliminate duplicated code in revocation table init/destroy functions Duane Griffin
2008-03-07 1:31 ` Duane Griffin
2008-03-07 1:31 ` Duane Griffin
2008-03-07 1:31 ` [PATCH 2/3] jbd2: replace potentially false assertion with if block Duane Griffin
2008-03-07 1:31 ` Duane Griffin
2008-03-07 21:23 ` Andreas Dilger
2008-03-08 13:33 ` Duane Griffin
2008-03-08 15:02 ` Christoph Hellwig
2008-03-08 16:40 ` Duane Griffin
2008-03-08 16:42 ` Christoph Hellwig
2008-03-08 18:37 ` Duane Griffin
2008-03-08 18:45 ` Christoph Hellwig [this message]
2008-03-07 1:31 ` [PATCH 3/3] jbd2: only create debugfs and stats entries if cache initialisation is successful Duane Griffin
2008-03-07 1:31 ` Duane Griffin
2008-03-07 21:24 ` Andreas Dilger
2008-03-07 21:52 ` [PATCH 1/3] jbd2: eliminate duplicated code in revocation table init/destroy functions Andreas Dilger
2008-03-08 0:05 ` Mingming Cao
2008-03-08 13:26 ` Duane Griffin
2008-03-08 13:20 ` Duane Griffin
2008-03-08 13:20 ` Duane Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080308184543.GA4284@infradead.org \
--to=hch@infradead.org \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=duaneg@dghda.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.