From: Gautham R Shenoy <ego@in.ibm.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Dhaval Giani <dhaval@linux.vnet.ibm.com>
Subject: [PATCH] x86: Don't send RESCHEDULE_VECTOR to offlined cpus
Date: Mon, 10 Mar 2008 17:44:03 +0530 [thread overview]
Message-ID: <20080310121403.GD17646@in.ibm.com> (raw)
x86: Don't send RESCHEDULE_VECTOR to offlined cpus.
From: Gautham R Shenoy <ego@in.ibm.com>
In the x86 native_smp_send_reschedule_function(), don't send the IPI if the
cpu has gone offline already. Warn nevertheless!!
Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>
---
arch/x86/kernel/smp_32.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/smp_32.c b/arch/x86/kernel/smp_32.c
index dc0cde9..4df9042 100644
--- a/arch/x86/kernel/smp_32.c
+++ b/arch/x86/kernel/smp_32.c
@@ -472,7 +472,10 @@ void flush_tlb_all(void)
*/
static void native_smp_send_reschedule(int cpu)
{
- WARN_ON(cpu_is_offline(cpu));
+ if (unlikely(cpu_is_offline(cpu))) {
+ WARN_ON(1);
+ return;
+ }
send_IPI_mask(cpumask_of_cpu(cpu), RESCHEDULE_VECTOR);
}
--
Thanks and Regards
gautham
next reply other threads:[~2008-03-10 12:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 12:14 Gautham R Shenoy [this message]
2008-03-10 12:24 ` [PATCH] x86: Don't send RESCHEDULE_VECTOR to offlined cpus Ingo Molnar
2008-03-10 12:54 ` Gautham R Shenoy
2008-03-10 15:32 ` Roel Kluin
2008-03-10 16:36 ` Gregory Haskins
2008-03-11 9:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080310121403.GD17646@in.ibm.com \
--to=ego@in.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.