All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <jbeulich@novell.com>
Cc: tglx@linutronix.de, hpa@zytor.com, markus.t.metzger@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: prevent unconditional writes to DebugCtl MSR
Date: Mon, 10 Mar 2008 18:14:09 +0100	[thread overview]
Message-ID: <20080310171409.GA24133@elte.hu> (raw)
In-Reply-To: <47D54185.76E4.0078.0@novell.com>


* Jan Beulich <jbeulich@novell.com> wrote:

> Otherwise, enabling (or better, subsequent disabling) of single 
> stepping would cause a kernel oops on CPUs not having this MSR.
> 
> The patch could have been added a conditional to the MSR write in 
> user_disable_single_step(), but centralizing the updates seems safer 
> and (looking forward) better manageable.

thanks Jan, applied.

	Ingo

  parent reply	other threads:[~2008-03-10 17:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 13:11 [PATCH] x86: prevent unconditional writes to DebugCtl MSR Jan Beulich
2008-03-10 15:56 ` Andi Kleen
2008-03-10 17:14 ` Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-04-18 19:43 Roland McGrath
2008-04-21 15:55 ` Ingo Molnar
2008-04-21 16:34   ` Jan Beulich
2008-04-21 21:30     ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080310171409.GA24133@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.t.metzger@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.