From: Andi Kleen <andi@firstfloor.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andi Kleen <andi@firstfloor.org>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty_ioctl: locking for tty_wait_until_sent
Date: Mon, 10 Mar 2008 23:28:35 +0100 [thread overview]
Message-ID: <20080310222835.GC9246@one.firstfloor.org> (raw)
In-Reply-To: <20080310220643.60f36bee@core>
On Mon, Mar 10, 2008 at 10:06:43PM +0000, Alan Cox wrote:
> On 10 Mar 2008 23:12:51 +0100
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
> >
> > > This function still depends on the big kernel lock in some cases. Push
> > > locking into the function ready for removal of the BKL from ioctl call
> > > paths.
> >
> > Didn't you forget the .ioctl -> .unlocked_ioctl change?
>
> We are not yet ready to unlock the device ioctl paths for tty. We still
Traditionally the usual is to first convert .ioctl to .unlocked_ioctl
and just slap lock_kernel around the whole ioctl handler and then
later move it down step by step.
I didn't read the code completely but I assume tty_ioctl would be that
handler. I guess i was wrong?
-Andi
next prev parent reply other threads:[~2008-03-10 22:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 21:53 [PATCH] tty_ioctl: locking for tty_wait_until_sent Alan Cox
2008-03-10 22:12 ` Andi Kleen
2008-03-10 22:06 ` Alan Cox
2008-03-10 22:28 ` Andi Kleen [this message]
2008-03-10 23:16 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080310222835.GC9246@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.