All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Len Brown <lenb@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	Alexey Starikovskiy <astarikovskiy@suse.de>,
	Andi Kleen <ak@suse.de>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: mpparse_{32,64}.c merge questions
Date: Wed, 12 Mar 2008 08:04:19 +0100	[thread overview]
Message-ID: <20080312070419.GA18216@elte.hu> (raw)
In-Reply-To: <200803111328.43314.lenb@kernel.org>


* Len Brown <lenb@kernel.org> wrote:

> > we dont, but please do _not_ "redesign" anything during unification.
> > 
> > try to keep it simple and bisectable. Lots of small patches. Stupid
> > #ifdefs if need to be. Pick the 32-bit version or the 64-bit version 
> > of any approach, if it's obvious that the unified version will still 
> > work fine. Ask if in doubt.
> 
> I agree with Ingo on the "keep it simple" merge steps..
> 
> I can't resist mentioning, however, what I'd like to see long term.
> 
> I'd like to see mpparse.o depend on CONFIG_MPS=y
> I'd like to be able to build CONFIG_ACPI=y and CONFIG_MPS=n
> 
> Andy Grover prototyped splititing MPS from ACPI a while back, but it 
> never made it upstream.

sure and agreed. And this absolutely has to happen in a separate 
patchset. Unification is done best by not changing much and by delaying 
any difficult change to as late in the unification effort as possible. 
(thus any non-trivial change, if it breaks things and has to be 
reverted, wont pull another 100 "easy" changes with itself)

	Ingo

      parent reply	other threads:[~2008-03-12  7:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <47CDB9D7.9030107@suse.de>
     [not found] ` <47CDBFD9.1050703@suse.de>
     [not found]   ` <20080304213552.GD8944@elte.hu>
2008-03-11 17:28     ` mpparse_{32,64}.c merge questions Len Brown
2008-03-11 17:34       ` Alexey Starikovskiy
2008-03-12  7:04       ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080312070419.GA18216@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=astarikovskiy@suse.de \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.