From: tony@bakeyournoodle.com (Tony Breeds)
To: "Guido Günther" <agx@sigxcpu.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/4] Ensure that pmu_sys_suspended exists in appropriate configs.
Date: Thu, 13 Mar 2008 08:20:05 +1100 [thread overview]
Message-ID: <20080312212005.GU6887@bakeyournoodle.com> (raw)
In-Reply-To: <20080312083857.GB19504@bogon.ms20.nix>
On Wed, Mar 12, 2008 at 09:38:57AM +0100, Guido Günther wrote:
> Hi Tony,
> On Wed, Mar 12, 2008 at 10:48:48AM +1100, Tony Breeds wrote:
> > pmu_sys_suspended is declared extern when:
> > defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
> > but only defined when:
> > defined(CONFIG_SUSPEND) && defined(CONFIG_PPC32)
> > which is wrong. Lets fix that.
> As I wrote, this isn't defined in my config:
>
> # CONFIG_SUSPEND is not set
> CONFIG_HIBERNATION=y
Hmm okay I thought I tested
for you.
I don't know if I missed it in one of your original posts, can you
supply your .config and compiler error. I can't see anywhere outside
of:
$ git grep -E -l pmu_sys_suspended --
drivers/macintosh/via-pmu-led.c
drivers/macintosh/via-pmu.c
include/linux/pmu.h
where pmu_sys_suspended is referenced and I'm having difficulty
understanding how CONFIG_HIBERNATION is affecting that.
Yours Tony
linux.conf.au http://www.marchsouth.org/
Jan 19 - 24 2009 The Australian Linux Technical Conference!
next prev parent reply other threads:[~2008-03-12 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 23:48 [PATCH 1/4] Ensure that pmu_sys_suspended exists in appropriate configs Tony Breeds
2008-03-11 23:48 ` [PATCH 4/4] Fix arch/powerpc/platforms/powermac/pic.c when !CONFIG_ADB_PMU Tony Breeds
2008-03-11 23:48 ` [PATCH 3/4] Fix drivers/macintosh/mediabay.c " Tony Breeds
2008-03-11 23:48 ` [PATCH 2/4] Fix build of modular drivers/macintosh/apm_emu.c Tony Breeds
2008-03-12 8:38 ` [PATCH 1/4] Ensure that pmu_sys_suspended exists in appropriate configs Guido Günther
2008-03-12 21:20 ` Tony Breeds [this message]
2008-03-13 8:30 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080312212005.GU6887@bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=agx@sigxcpu.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.