All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Bryan Wu <cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH 0/6] Blackfin I2C TWI driver updates
Date: Thu, 13 Mar 2008 13:03:32 +0100	[thread overview]
Message-ID: <20080313130332.46af8228@hyperion.delvare> (raw)
In-Reply-To: <386072610803121907y499903ban37456d06d36a07a8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Thu, 13 Mar 2008 10:07:07 +0800, Bryan Wu wrote:
> Actually, I plan to send out these for 2.6.26 at first. But found
> following BF54x compiling error:
> 
> --
> drivers/i2c/busses/i2c-bfin-twi.c: In function 'bfin_twi_handle_interrupt':
> drivers/i2c/busses/i2c-bfin-twi.c:67: error: implicit declaration of
> function 'bfin_read_TWI_INT_STAT'
> drivers/i2c/busses/i2c-bfin-twi.c:68: error: implicit declaration of
> function 'bfin_read_TWI_MASTER_STAT'
> drivers/i2c/busses/i2c-bfin-twi.c:73: error: implicit declaration of
> function 'bfin_write_TWI_XMT_DATA8'
> drivers/i2c/busses/i2c-bfin-twi.c:80: error: implicit declaration of
> function 'bfin_write_TWI_MASTER_CTL'
> drivers/i2c/busses/i2c-bfin-twi.c:80: error: implicit declaration of
> function 'bfin_read_TWI_MASTER_CTL'
> drivers/i2c/busses/i2c-bfin-twi.c:87: error: implicit declaration of
> function 'bfin_write_TWI_INT_STAT'
> drivers/i2c/busses/i2c-bfin-twi.c:93: error: implicit declaration of
> function 'bfin_read_TWI_RCV_DATA8'
> drivers/i2c/busses/i2c-bfin-twi.c:118: error: implicit declaration of
> function 'bfin_write_TWI_INT_MASK'
> drivers/i2c/busses/i2c-bfin-twi.c:119: error: implicit declaration of
> function 'bfin_write_TWI_MASTER_STAT'
> drivers/i2c/busses/i2c-bfin-twi.c: In function 'bfin_twi_master_xfer':
> drivers/i2c/busses/i2c-bfin-twi.c:227: error: implicit declaration of
> function 'bfin_read_TWI_CONTROL'
> drivers/i2c/busses/i2c-bfin-twi.c:251: error: implicit declaration of
> function 'bfin_write_TWI_MASTER_ADDR'
> drivers/i2c/busses/i2c-bfin-twi.c:256: error: implicit declaration of
> function 'bfin_write_TWI_FIFO_CTL'
> drivers/i2c/busses/i2c-bfin-twi.c: In function 'i2c_bfin_twi_suspend':
> drivers/i2c/busses/i2c-bfin-twi.c:520: error: implicit declaration of
> function 'bfin_write_TWI_CONTROL'
> drivers/i2c/busses/i2c-bfin-twi.c: In function 'i2c_bfin_twi_probe':
> drivers/i2c/busses/i2c-bfin-twi.c:545: error: 'IRQ_TWI' undeclared
> (first use in this function)
> drivers/i2c/busses/i2c-bfin-twi.c:545: error: (Each undeclared
> identifier is reported only once
> drivers/i2c/busses/i2c-bfin-twi.c:545: error: for each function it appears in.)
> drivers/i2c/busses/i2c-bfin-twi.c:572: error: implicit declaration of
> function 'bfin_write_TWI_CLKDIV'
> make[3]: *** [drivers/i2c/busses/i2c-bfin-twi.o] Error 1
> make[2]: *** [drivers/i2c/busses] Error 2
> make[1]: *** [drivers/i2c] Error 2
> make: *** [drivers] Error 2
> --
> 
> But as you said, it is -rc5 now. If these can be merged in 2.6.26, it
> is OK for me.

Maybe you can provide a fix for just this build problem? This I would
possibly push into 2.6.25, and then the rest of your updates go on top
of it for 2.6.26.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

      parent reply	other threads:[~2008-03-13 12:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-12 16:25 [PATCH 0/6] Blackfin I2C TWI driver updates Bryan Wu
     [not found] ` <1205479360-25240-1-git-send-email-cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2008-03-12 18:37   ` Jean Delvare
     [not found]     ` <20080312193718.1aa86caf-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-13  2:07       ` Bryan Wu
     [not found]         ` <386072610803121907y499903ban37456d06d36a07a8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-13  5:43           ` Kalle Pokki
     [not found]             ` <Pine.LNX.4.64.0803130726410.26435-er0LZAA46r2WwDxiJSwuDc1vFkv34tBQrE5yTffgRl4@public.gmane.org>
2008-03-13  7:50               ` Bryan Wu
     [not found]                 ` <386072610803130050j47f2659bpbf53199c7dec4916-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-13 14:34                   ` Jean Delvare
     [not found]                     ` <20080313153412.6c978e24-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-13 16:25                       ` Bryan Wu
     [not found]                         ` <386072610803130925r3353032kc4e47d4a0948dba4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-13 17:13                           ` Jean Delvare
2008-03-13 12:03           ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080313130332.46af8228@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=cooloney-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.