From: Andrew Morton <akpm@linux-foundation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: ak@suse.de, linux-kernel@vger.kernel.org, mingo@elte.hu,
rjw@sisk.pl, len.brown@intel.com, stable@kernel.org
Subject: Re: fix aperture vs. suspend problem
Date: Thu, 13 Mar 2008 15:32:48 -0700 [thread overview]
Message-ID: <20080313153248.f43bbce3.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080313100531.GA3399@elf.ucw.cz>
On Thu, 13 Mar 2008 11:05:31 +0100
Pavel Machek <pavel@ucw.cz> wrote:
>
> aperture_64.c takes a piece of memory and makes it into iommu
> window... but such window may not be saved by swsusp -- that leads to
> oops during suspend.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
> index 608152a..88747f3 100644
> --- a/arch/x86/kernel/aperture_64.c
> +++ b/arch/x86/kernel/aperture_64.c
> @@ -18,6 +18,7 @@ #include <linux/pci_ids.h>
> #include <linux/pci.h>
> #include <linux/bitops.h>
> #include <linux/ioport.h>
> +#include <linux/suspend.h>
> #include <asm/e820.h>
> #include <asm/io.h>
> #include <asm/gart.h>
> @@ -76,6 +77,7 @@ static u32 __init allocate_aperture(void
> printk(KERN_INFO "Mapping aperture over %d KB of RAM @ %lx\n",
> aper_size >> 10, __pa(p));
> insert_aperture_resource((u32)__pa(p), aper_size);
> + register_nosave_region((u32)__pa(p) >> PAGE_SHIFT, (u32)__pa(p+aper_size) >> PAGE_SHIFT);
>
> return (u32)__pa(p);
> }
>
This is also needed in 2.6.24, perhaps earlier?
next prev parent reply other threads:[~2008-03-13 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 10:05 fix aperture vs. suspend problem Pavel Machek
2008-03-13 20:31 ` Rafael J. Wysocki
2008-03-13 22:32 ` Andrew Morton [this message]
2008-03-13 22:38 ` Pavel Machek
2008-03-14 8:14 ` Romano Giannetti
2008-03-14 19:30 ` Pavel Machek
2008-03-21 12:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313153248.f43bbce3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.