From: Holger Macht <hmacht@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH libata-dev#upstream-fixes] libata-acpi: improve dock event handling
Date: Thu, 13 Mar 2008 19:19:46 +0100 [thread overview]
Message-ID: <20080313181946.GD26183@homac.suse.de> (raw)
In-Reply-To: <47D7691B.3080107@gmail.com>
On Wed 12. Mar - 14:24:43, Tejun Heo wrote:
> Improve ACPI hotplug handling such that dock event is handled properly.
>
> * Register handlers for dock events.
>
> * Directly detach device on EJECT_REQUEST instead of signaling hotplug
> event. This prevents libata from accessing severed controller
> and/or device.
>
> * While at it, use named constants for ACPI events and move uevent
> signaling inside host lock.
>
> Original patch and testing by Holger Macht.
Grrrr, unfortunately, the patch still seems to be not perfect:
http://marc.info/?l=linux-acpi&m=120543202908662&w=2
Are you sure access to the device (/dev/srX) is locked before
ata_acpi_dev_notify() returns?
Regards,
Holger
next prev parent reply other threads:[~2008-03-13 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 5:24 [PATCH libata-dev#upstream-fixes] libata-acpi: improve dock event handling Tejun Heo
2008-03-13 18:19 ` Holger Macht [this message]
2008-03-19 6:44 ` Tejun Heo
2008-03-17 12:27 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313181946.GD26183@homac.suse.de \
--to=hmacht@suse.de \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.