From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fix SDL mouse events processing
Date: Thu, 13 Mar 2008 20:50:51 +0100 [thread overview]
Message-ID: <20080313195051.GA17899@volta.aurel32.net> (raw)
In-Reply-To: <20080305135453.GE9786@implementation.uk.xensource.com>
On Wed, Mar 05, 2008 at 01:54:53PM +0000, Samuel Thibault wrote:
> Here is a revamped patch:
>
> This fixes SDL mouse events processing:
> - GetRelativeMouseState() always returns the last position, so when the
> polling loop gets several mouse events in one go, we would send
> useless 'no move' events, let's avoid that.
> - So as to make sure we don't miss any mouse click / double click, we
> should not use GetRelativeMouseState() to get the button state, but
> rather keep records of the button state ourselves (I've requested SDL
> developers to provide it directly in the event in SDL 1.3).
> - bev->state doesn't contain the button state but whether the event is a press
> or a release. Use bev->button instead.
This patch does not apply anymore. Could you please to redo it against
the current CVS?
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
next prev parent reply other threads:[~2008-03-13 19:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 11:47 [PATCH] ioemu: fix SDL mouse events processing Samuel Thibault
2008-03-05 12:18 ` [Qemu-devel] [PATCH] " Samuel Thibault
2008-03-05 13:09 ` Johannes Schindelin
2008-03-05 13:51 ` Samuel Thibault
2008-03-05 13:54 ` Samuel Thibault
2008-03-05 14:08 ` Johannes Schindelin
2008-03-13 19:50 ` Aurelien Jarno [this message]
2008-03-13 23:37 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313195051.GA17899@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.