From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, avorontsov@ru.mvista.com
Subject: Re: [patch 2.6.25-rc5 1/2] gpiolib: dynamic gpio number allocation
Date: Thu, 13 Mar 2008 21:52:57 -0800 [thread overview]
Message-ID: <200803132252.58101.david-b@pacbell.net> (raw)
In-Reply-To: <20080313191747.dede60c3.akpm@linux-foundation.org>
On Thursday 13 March 2008, Andrew Morton wrote:
> > > > Actually, I tried IDRs for a while and they broke platforms
> > > > which needed to initialize and use GPIOs early: before kmalloc
> > > > would work. A real PITA that was -- and slow too.
> > >
> > > If IDRs were slow, that linear search will be glacial.
> >
> > The slowness of IDRs was needing to use them for the
> > routine lookups ... versus the current array index,
> > which costs a fraction of an instruction cycle and
> > doesn't need separate locks.
> >
> > Or were you implying they should be used for something
> > other than mapping GPIO numbers to controllers/state?
>
> For dynamic allocation. There should be no need for lookups outside
> register/unregister.
So -- a secondary data structure used only for allocation?
With the primary one as it is now?
If allocation were a hotspot something like that might be
worth considering ... though such duplication is usually
error prone. But it's not; such allocation is a rarity.
> Where did the CONFIG_NR_GPIOS discussion disappear to?
http://marc.info/?l=linux-kernel&m=120545979527097&w=2
I could maybe see a CONFIG_NR_EXTRA_GPIOS.
next prev parent reply other threads:[~2008-03-14 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 22:49 [patch 2.6.25-rc5 1/2] gpiolib: dynamic gpio number allocation David Brownell
2008-03-13 23:00 ` Andrew Morton
2008-03-13 23:18 ` David Brownell
2008-03-13 23:28 ` Andrew Morton
2008-03-13 23:54 ` Anton Vorontsov
2008-03-14 0:53 ` David Brownell
2008-03-14 2:17 ` Andrew Morton
2008-03-14 5:52 ` David Brownell [this message]
2008-03-14 1:54 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803132252.58101.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.