From: Dave Jones <davej@codemonkey.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Brownell <david-b@pacbell.net>,
linux-kernel@vger.kernel.org, avorontsov@ru.mvista.com
Subject: Re: [patch 2.6.25-rc5 2/2] gpiochip_reserve()
Date: Thu, 13 Mar 2008 21:33:03 -0400 [thread overview]
Message-ID: <20080314013303.GA15600@codemonkey.org.uk> (raw)
In-Reply-To: <20080313160606.219166f5.akpm@linux-foundation.org>
On Thu, Mar 13, 2008 at 04:06:06PM -0700, Andrew Morton wrote:
> On Thu, 13 Mar 2008 14:52:21 -0800
> David Brownell <david-b@pacbell.net> wrote:
>
> > +int __init __must_check gpiochip_reserve(int start, int ngpio)
>
> I applaud the addition of __msut_check to a newly-added function of this
> kind, but we usually only add the tag to the declaration, not to the
> definition as well.
A bit unfortunate really, given that use of ctags and friends in some editors
jumps to the first definition they come across, so if the prototype is stuffed
somewhere in include/, it shows the definitions from drivers or fs or wherever
that doesn't have the tag.
Given it doesn't cost us anything except a few more bytes in the source code,
is consistency such a bad thing?
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2008-03-14 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 22:52 [patch 2.6.25-rc5 2/2] gpiochip_reserve() David Brownell
2008-03-13 23:06 ` Andrew Morton
2008-03-14 1:33 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080314013303.GA15600@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.