From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: [PATCH] x86: fix variable_test_bit() asmconstraints Date: Fri, 14 Mar 2008 13:59:38 +0000 Message-ID: <20080314135938.GN4358@implementation.uk.xensource.com> References: <47DA6E53.76E4.0078.0@novell.com> <47DA90EE.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <47DA90EE.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com, Keir Fraser List-Id: xen-devel@lists.xenproject.org Jan Beulich, le Fri 14 Mar 2008 13:51:26 +0000, a écrit : > >memory-clobber would be needed for the atomic ops, but a dummy memory > >operand would suffice for non-atomic ops. I used memory clobber everywhere > > Atomic ops imply a barrier (otherwise the compiler can defeat the > purpose of the atomic operation). The non-atomic ones don't need a > dummy operand, but one that precisely describes the place in memory > that changes. Mmm, won't that unnecessarily make the compiler put code to compute that place? Samuel