From: Theodore Tso <tytso@mit.edu>
To: Andreas Dilger <adilger@sun.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH][10/28] e2fsprogs-uninit.patch
Date: Sat, 15 Mar 2008 15:41:20 -0400 [thread overview]
Message-ID: <20080315194120.GI27847@mit.edu> (raw)
In-Reply-To: <20080202083444.GK31694@webber.adilger.int>
What is the intended use of the SF_DO_CSUM flag? I see where it is
defined, and where it gets sets, but as far as I can tell nothing
actually tests for it or uses it.
- Ted
On Sat, Feb 02, 2008 at 01:34:44AM -0700, Andreas Dilger wrote:
> Index: e2fsprogs-1.40.5/lib/ext2fs/ext2fs.h
>
> +#define EXT2_SF_DO_CSUM 0x0020
>
> Index: e2fsprogs-1.40.5/lib/ext2fs/inode.c
> ===================================================================
> --- e2fsprogs-1.40.5.orig/lib/ext2fs/inode.c
> +++ e2fsprogs-1.40.5/lib/ext2fs/inode.c
> @@ -167,6 +167,9 @@ errcode_t ext2fs_open_inode_scan(ext2_fi
> if (EXT2_HAS_COMPAT_FEATURE(fs->super,
> EXT2_FEATURE_COMPAT_LAZY_BG))
> scan->scan_flags |= EXT2_SF_DO_LAZY;
> + if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
> + EXT4_FEATURE_RO_COMPAT_GDT_CSUM))
> + scan->scan_flags |= EXT2_SF_DO_LAZY | EXT2_SF_DO_CSUM;
next prev parent reply other threads:[~2008-03-15 19:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 7:59 [PATCH][0/28] Lustre e2fsprogs patch series Andreas Dilger
2008-02-02 8:14 ` [PATCH][1/28] e2fsprogs-specdotin.patch Andreas Dilger
2008-02-02 8:16 ` [PATCH] [2/28] e2fsprogs-eacheck.patch Andreas Dilger
2008-02-02 8:17 ` [PATCH][3/28] e2fsprogs-extended_ops.patch Andreas Dilger
2008-02-02 8:20 ` [PATCH][4/28] e2fsprogs-tests-f_unsorted_EAs.patch Andreas Dilger
2008-02-02 8:22 ` [PATCH][5/28] e2fsprogs-tests-f_ea_checks.patch Andreas Dilger
2008-02-02 8:25 ` [PATCH][6/28] e2fsprogs-nlinks.patch Andreas Dilger
2008-02-02 8:25 ` [PATCH][0/28] e2fsprogs-extents.patch Andreas Dilger
2008-02-02 8:27 ` [PATCH][7/28] e2fsprogs-extents.patch Andreas Dilger
2008-02-18 17:56 ` Eric Sandeen
2008-02-18 18:12 ` Eric Sandeen
2008-02-18 19:53 ` Theodore Tso
2008-02-18 20:48 ` Eric Sandeen
2008-02-18 22:09 ` Theodore Tso
2008-02-19 4:35 ` Andreas Dilger
2008-02-02 8:29 ` [PATCH][8/28] e2fsprogs-config-before-cmdline.patch Andreas Dilger
2008-02-02 8:30 ` [PATCH][9/28] e2fsprogs-SLES10--m-support.patch Andreas Dilger
2008-02-02 8:34 ` [PATCH][10/28] e2fsprogs-uninit.patch Andreas Dilger
2008-03-15 19:41 ` Theodore Tso [this message]
2008-03-16 0:34 ` Andreas Dilger
2008-03-17 12:33 ` Theodore Tso
2008-02-02 8:36 ` [PATCH][11/28] e2fsprogs-nlinks-flag.patch Andreas Dilger
2008-02-02 8:36 ` [PATCH][12/28] e2fsprogs-expand-extra-isize.patch Andreas Dilger
2008-02-02 8:40 ` [PATCH][14/28] e2fsprogs-tests-f_expisize_ea_del.patch Andreas Dilger
2008-02-02 8:41 ` [PATCH][15/28] e2fsprogs-ibadness-counter.patch Andreas Dilger
2008-02-02 8:43 ` [PATCH][16/28] e2fsprogs-tests-f_ibadness.patch Andreas Dilger
2008-02-02 8:46 ` [PATCH][18/28] e2fsprogs-tests-f_random_corruption.patch Andreas Dilger
2008-02-02 8:47 ` [PATCH][19/28] e2fsprogs-stride_option.patch Andreas Dilger
2008-02-02 8:48 ` [PATCH][20/28] e2fsprogs-mmp.patch Andreas Dilger
2008-02-02 8:49 ` [PATCH][21/28] e2fsprogs-journal_chksum.patch Andreas Dilger
2008-02-02 8:54 ` [PATCH][25/28] e2fsprogs-i_size-corruption.patch Andreas Dilger
2008-02-02 8:54 ` [PATCH][26/28] e2fsprogs-fiemap.patch Andreas Dilger
2008-02-02 8:56 ` [PATCH][27/28] e2fsprogs-debugfs-supported_features.patch Andreas Dilger
2008-02-02 8:57 ` [PATCH][28/28] e2fsprogs-lts-make_rpms.patch Andreas Dilger
2008-02-11 4:19 ` [PATCH][0/28] Lustre e2fsprogs patch series Theodore Tso
2008-02-11 10:22 ` Aneesh Kumar K.V
2008-02-11 20:09 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080315194120.GI27847@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.