From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754929AbYCQG7v (ORCPT ); Mon, 17 Mar 2008 02:59:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752168AbYCQG7o (ORCPT ); Mon, 17 Mar 2008 02:59:44 -0400 Received: from one.firstfloor.org ([213.235.205.2]:57977 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbYCQG7n (ORCPT ); Mon, 17 Mar 2008 02:59:43 -0400 Date: Mon, 17 Mar 2008 08:02:08 +0100 From: Andi Kleen To: Yinghai Lu Cc: Andi Kleen , linux-kernel@vger.kernel.org, pj@sgi.com, linux-mm@kvack.org, nickpiggin@yahoo.com.au Subject: Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator Message-ID: <20080317070208.GC27015@one.firstfloor.org> References: <20080317258.659191058@firstfloor.org> <20080317015825.0C0171B41E0@basil.firstfloor.org> <86802c440803161919h20ed9f78k6e3798ef56668638@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86802c440803161919h20ed9f78k6e3798ef56668638@mail.gmail.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > node_boot_start is not page aligned? It is, but it is not necessarily GB aligned and without this change sometimes alloc_bootmem when requesting GB alignment doesn't return GB aligned memory. This was a nasty problem that took some time to track down. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 17 Mar 2008 08:02:08 +0100 From: Andi Kleen Subject: Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator Message-ID: <20080317070208.GC27015@one.firstfloor.org> References: <20080317258.659191058@firstfloor.org> <20080317015825.0C0171B41E0@basil.firstfloor.org> <86802c440803161919h20ed9f78k6e3798ef56668638@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86802c440803161919h20ed9f78k6e3798ef56668638@mail.gmail.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Yinghai Lu Cc: Andi Kleen , linux-kernel@vger.kernel.org, pj@sgi.com, linux-mm@kvack.org, nickpiggin@yahoo.com.au List-ID: > node_boot_start is not page aligned? It is, but it is not necessarily GB aligned and without this change sometimes alloc_bootmem when requesting GB alignment doesn't return GB aligned memory. This was a nasty problem that took some time to track down. -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org