From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Frej Drejhammar <frej.drejhammar@gmail.com>,
video4linux-list@redhat.com, Trent Piepho <xyzzy@speakeasy.org>
Subject: Re: [PATCH 0 of 2] cx88: Enable additional cx2388x features. Version 2
Date: Mon, 17 Mar 2008 10:14:33 -0300 [thread overview]
Message-ID: <20080317101433.42e56c4c@gaivota> (raw)
In-Reply-To: <200803171133.58855.hverkuil@xs4all.nl>
On Mon, 17 Mar 2008 11:33:58 +0100
Hans Verkuil <hverkuil@xs4all.nl> wrote:
> That's not quite what I meant. I'm responsible of all the MPEG controls,
> so I'm definitely all for exposing hardware features to the user :-)
>
> What I want to prevent is adding controls as a workaround for what might
> be a driver bug. So in this case I wonder whether chroma AGC shouldn't
> be enabled in the cx88 driver as it is for cx2584x.
>
> Looking at the cx25840 datasheet it basically says that it should always
> be enabled except for component input (YPrPb) or SECAM. So I would
> suggest doing the same in cx88 rather than adding a control. Only if
> there are cases where Chroma AGC harms the picture quality rather than
> improves it, then the addition of a control might become important.
IMO, the better would be to add both Chroma AGC and Color Killer controls as a generic control.
The default value for Chroma AGC should be changed to match the datasheet recommended
way (0 for SECAM, 1 for PAL/NTSC).
Cheers,
Mauro
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-03-17 13:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 12:49 [PATCH 0 of 2] cx88: Enable additional cx2388x features. Version 2 Frej Drejhammar
2008-03-16 12:49 ` [PATCH 1 of 2] cx88: Add user control for chroma AGC Frej Drejhammar
2008-03-16 12:49 ` [PATCH 2 of 2] cx88: Add user control for color killer Frej Drejhammar
2008-03-16 13:42 ` [PATCH 0 of 2] cx88: Enable additional cx2388x features. Version 2 Hans Verkuil
2008-03-16 15:09 ` Frej Drejhammar
2008-03-16 20:28 ` Trent Piepho
2008-03-16 21:05 ` Frej Drejhammar
2008-03-16 23:27 ` Vanessa Ezekowitz
2008-03-17 10:33 ` Hans Verkuil
2008-03-17 13:14 ` Mauro Carvalho Chehab [this message]
2008-03-17 16:17 ` Frej Drejhammar
[not found] ` <47DDB7A7.6000400@foks.us>
2008-03-17 1:40 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080317101433.42e56c4c@gaivota \
--to=mchehab@infradead.org \
--cc=frej.drejhammar@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=video4linux-list@redhat.com \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.