From: Rusty Russell <rusty@rustcorp.com.au>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_net/virtio_ring: fix race in enable_cb
Date: Mon, 17 Mar 2008 23:10:52 +1100 [thread overview]
Message-ID: <200803172310.52460.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200803170730.44218.borntraeger@de.ibm.com>
On Monday 17 March 2008 17:30:44 Christian Borntraeger wrote:
> > Are you seeing the "Unlikely: restart svq failed" message in the logs?
> > If not, I don't think it can be this race.
>
> No, I dont see the message, but this message only happens for guest->host
> traffic in the xmit function.
Interesting you don't see this. Or is it just on that load that you don't see
it?
> I was fixing the poll function - which has no
> printk.
> I added the disable_cb in the xmit function only to adopt to changed
> enable_cb semantics.
>
> I double checked my theory with a printk in enable_cb. The more_used check
> was true several times for the receiving virtqueue.
Excellent, thanks.
I applied your patch, and have asked Linus to pull that and my other qeued
virtio fixes.
Cheers,
Rusty.
next prev parent reply other threads:[~2008-03-17 12:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 13:17 [PATCH] virtio_net/virtio_ring: fix race in enable_cb Christian Borntraeger
2008-03-17 1:48 ` Rusty Russell
2008-03-17 1:48 ` Rusty Russell
2008-03-17 6:30 ` Christian Borntraeger
2008-03-17 6:30 ` Christian Borntraeger
2008-03-17 12:10 ` Rusty Russell [this message]
2008-03-17 12:45 ` Christian Borntraeger
2008-03-17 12:45 ` Christian Borntraeger
2008-03-17 12:10 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2008-03-14 13:17 Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803172310.52460.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=borntraeger@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.