From: Olof Johansson <olof@lixom.net>
To: "Nelson, Shannon" <shannon.nelson@intel.com>
Cc: hskinnemoen@atmel.com, "Sosnowski,
Maciej" <maciej.sosnowski@intel.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
pasemi-linux@ozlabs.org, "Williams,
Dan J" <dan.j.williams@intel.com>
Subject: Re: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine
Date: Mon, 17 Mar 2008 19:21:31 -0500 [thread overview]
Message-ID: <20080318002131.GA382@lixom.net> (raw)
In-Reply-To: <BAE9DCEF64577A439B3A37F36F9B691C043E6716@orsmsx418.amr.corp.intel.com>
Hi,
On Mon, Mar 17, 2008 at 01:34:05PM -0700, Nelson, Shannon wrote:
> In the future please copy Maciej as one of "the DMA guys" as he has
> taken over ioatdma for me. Beyond that, one little picky comment
> below...
Time to set up a list, or have everyone monitor lkml, I'd say. I'd
prefer the former.
> >+static unsigned int channels = 4;
> >+module_param(channels, uint, S_IRUGO);
> >+MODULE_PARM_DESC(channels, "Number of channels for copy
> >(default: 2)");
>
> Is the number of channels defaulting to 2 or 4?
Ah, yes, good catch.
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: "Nelson, Shannon" <shannon.nelson@intel.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"Sosnowski, Maciej" <maciej.sosnowski@intel.com>,
linux-kernel@vger.kernel.org, pasemi-linux@ozlabs.org,
linuxppc-dev@ozlabs.org, hskinnemoen@atmel.com
Subject: Re: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine
Date: Mon, 17 Mar 2008 19:21:31 -0500 [thread overview]
Message-ID: <20080318002131.GA382@lixom.net> (raw)
In-Reply-To: <BAE9DCEF64577A439B3A37F36F9B691C043E6716@orsmsx418.amr.corp.intel.com>
Hi,
On Mon, Mar 17, 2008 at 01:34:05PM -0700, Nelson, Shannon wrote:
> In the future please copy Maciej as one of "the DMA guys" as he has
> taken over ioatdma for me. Beyond that, one little picky comment
> below...
Time to set up a list, or have everyone monitor lkml, I'd say. I'd
prefer the former.
> >+static unsigned int channels = 4;
> >+module_param(channels, uint, S_IRUGO);
> >+MODULE_PARM_DESC(channels, "Number of channels for copy
> >(default: 2)");
>
> Is the number of channels defaulting to 2 or 4?
Ah, yes, good catch.
-Olof
next prev parent reply other threads:[~2008-03-18 0:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 23:39 [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine Olof Johansson
2008-03-06 23:39 ` Olof Johansson
2008-03-07 0:31 ` Stephen Rothwell
2008-03-07 0:31 ` Stephen Rothwell
2008-03-07 1:35 ` Olof Johansson
2008-03-11 7:06 ` Andrew Morton
2008-03-11 7:06 ` Andrew Morton
2008-03-11 14:25 ` Olof Johansson
2008-03-11 14:25 ` Olof Johansson
2008-03-11 17:53 ` Andrew Morton
2008-03-11 17:53 ` Andrew Morton
2008-03-11 18:15 ` Dan Williams
2008-03-11 18:15 ` Dan Williams
2008-03-11 18:29 ` Kumar Gala
2008-03-11 18:29 ` Kumar Gala
2008-03-11 20:37 ` Dan Williams
2008-03-11 20:37 ` Dan Williams
2008-03-11 17:04 ` [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine Dan Williams
2008-03-11 17:04 ` Dan Williams
2008-03-13 19:54 ` Olof Johansson
2008-03-13 19:54 ` Olof Johansson
2008-03-13 22:29 ` Dan Williams
2008-03-13 22:29 ` Dan Williams
2008-03-13 23:14 ` Olof Johansson
2008-03-14 0:06 ` Dan Williams
2008-03-16 21:30 ` [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine Olof Johansson
2008-03-16 21:30 ` Olof Johansson
2008-03-17 18:46 ` Dan Williams
2008-03-17 18:46 ` Dan Williams
2008-03-18 0:27 ` Olof Johansson
2008-03-18 0:27 ` Olof Johansson
2008-03-17 20:34 ` [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine Nelson, Shannon
2008-03-17 20:34 ` Nelson, Shannon
2008-03-18 0:21 ` Olof Johansson [this message]
2008-03-18 0:21 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080318002131.GA382@lixom.net \
--to=olof@lixom.net \
--cc=dan.j.williams@intel.com \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=maciej.sosnowski@intel.com \
--cc=pasemi-linux@ozlabs.org \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.