All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linuxppc-dev@ozlabs.org, pasemi-linux@ozlabs.org,
	shannon.nelson@intel.com, linux-kernel@vger.kernel.org,
	hskinnemoen@atmel.com
Subject: Re: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine
Date: Mon, 17 Mar 2008 19:27:26 -0500	[thread overview]
Message-ID: <20080318002726.GA481@lixom.net> (raw)
In-Reply-To: <e9c3a7c20803171146m5a7f0e11m31e074634de22b42@mail.gmail.com>

On Mon, Mar 17, 2008 at 11:46:39AM -0700, Dan Williams wrote:
> Looks good, makes me want to go back and cleanup iop-adma a bit.  A
> few fyi's below, but no other review comments.
> 
> >  Note that this still needs to go on top of the powerpc.git tree due to the
> >  pasemi_dma.h updates that this driver depends on. I suggest merging this
> >  through pasemi.git->powerpc.git->linus with an Acked-by from the DMA guys.
> 
> Ok, it still may not compile in mainline until after 2.6.26-rc1 due to
> additional dmaengine cleanups like the ack-to-flags change I posted
> earlier.  Any better way to handle this?  Go through -mm?

Either go through -mm where Andrew can keep it applied in appropriate
order and send upstream, or just merge it late. It's a new driver, and
they're normally OK to go in a little later. That might be the easiest
solution in this case.

> Acked-by: Dan Williams <dan.j.williams@intel.com>

Thanks!

-Olof

WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: Dan Williams <dan.j.williams@intel.com>
Cc: shannon.nelson@intel.com, linux-kernel@vger.kernel.org,
	pasemi-linux@ozlabs.org, linuxppc-dev@ozlabs.org,
	hskinnemoen@atmel.com
Subject: Re: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine
Date: Mon, 17 Mar 2008 19:27:26 -0500	[thread overview]
Message-ID: <20080318002726.GA481@lixom.net> (raw)
In-Reply-To: <e9c3a7c20803171146m5a7f0e11m31e074634de22b42@mail.gmail.com>

On Mon, Mar 17, 2008 at 11:46:39AM -0700, Dan Williams wrote:
> Looks good, makes me want to go back and cleanup iop-adma a bit.  A
> few fyi's below, but no other review comments.
> 
> >  Note that this still needs to go on top of the powerpc.git tree due to the
> >  pasemi_dma.h updates that this driver depends on. I suggest merging this
> >  through pasemi.git->powerpc.git->linus with an Acked-by from the DMA guys.
> 
> Ok, it still may not compile in mainline until after 2.6.26-rc1 due to
> additional dmaengine cleanups like the ack-to-flags change I posted
> earlier.  Any better way to handle this?  Go through -mm?

Either go through -mm where Andrew can keep it applied in appropriate
order and send upstream, or just merge it late. It's a new driver, and
they're normally OK to go in a little later. That might be the easiest
solution in this case.

> Acked-by: Dan Williams <dan.j.williams@intel.com>

Thanks!

-Olof


  reply	other threads:[~2008-03-18  0:27 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 23:39 [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine Olof Johansson
2008-03-06 23:39 ` Olof Johansson
2008-03-07  0:31 ` Stephen Rothwell
2008-03-07  0:31   ` Stephen Rothwell
2008-03-07  1:35   ` Olof Johansson
2008-03-11  7:06 ` Andrew Morton
2008-03-11  7:06   ` Andrew Morton
2008-03-11 14:25   ` Olof Johansson
2008-03-11 14:25     ` Olof Johansson
2008-03-11 17:53     ` Andrew Morton
2008-03-11 17:53       ` Andrew Morton
2008-03-11 18:15       ` Dan Williams
2008-03-11 18:15         ` Dan Williams
2008-03-11 18:29         ` Kumar Gala
2008-03-11 18:29           ` Kumar Gala
2008-03-11 20:37           ` Dan Williams
2008-03-11 20:37             ` Dan Williams
2008-03-11 17:04 ` [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine Dan Williams
2008-03-11 17:04   ` Dan Williams
2008-03-13 19:54   ` Olof Johansson
2008-03-13 19:54     ` Olof Johansson
2008-03-13 22:29     ` Dan Williams
2008-03-13 22:29       ` Dan Williams
2008-03-13 23:14       ` Olof Johansson
2008-03-14  0:06         ` Dan Williams
2008-03-16 21:30 ` [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine Olof Johansson
2008-03-16 21:30   ` Olof Johansson
2008-03-17 18:46   ` Dan Williams
2008-03-17 18:46     ` Dan Williams
2008-03-18  0:27     ` Olof Johansson [this message]
2008-03-18  0:27       ` Olof Johansson
2008-03-17 20:34   ` [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine Nelson, Shannon
2008-03-17 20:34     ` Nelson, Shannon
2008-03-18  0:21     ` Olof Johansson
2008-03-18  0:21       ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080318002726.GA481@lixom.net \
    --to=olof@lixom.net \
    --cc=dan.j.williams@intel.com \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=pasemi-linux@ozlabs.org \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.