From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] DSP: Fix dsp_common.c compile breakage
Date: Tue, 18 Mar 2008 11:18:52 +0200 [thread overview]
Message-ID: <20080318091852.GF20921@atomide.com> (raw)
In-Reply-To: <1205783450-16673-2-git-send-email-me@felipebalbi.com>
* Felipe Balbi <me@felipebalbi.com> [080317 21:49]:
> Recent changes broke compilation for omap1.
>
> Signed-off-by: Felipe Balbi <me@felipebalbi.com>
> ---
> drivers/dsp/dspgateway/dsp_common.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dsp/dspgateway/dsp_common.c b/drivers/dsp/dspgateway/dsp_common.c
> index af97ce1..aeeadf4 100644
> --- a/drivers/dsp/dspgateway/dsp_common.c
> +++ b/drivers/dsp/dspgateway/dsp_common.c
> @@ -478,7 +478,7 @@ void dsp_cpustat_set_icrmask(u16 mask)
> mutex_unlock(&cpustat.lock);
> }
>
> -#ifdef CONFIG_ARCH_OMAP1
> +#if defined(CONFIG_ARCH_OMAP1) && defined(CONFIG_OMAP_MMU_FWK)
> void omap_dsp_request_mpui(void)
> {
> mutex_lock(&cpustat.lock);
> @@ -594,7 +594,7 @@ void dsp_unregister_mem_cb(void) { }
>
> arch_initcall(omap_dsp_init);
>
> -#ifdef CONFIG_ARCH_OMAP1
> +#if defined(CONFIG_ARCH_OMAP1) && defined(CONFIG_OMAP_MMU_FWK)
> EXPORT_SYMBOL(omap_dsp_request_mpui);
> EXPORT_SYMBOL(omap_dsp_release_mpui);
> EXPORT_SYMBOL(omap_dsp_request_mem);
Pushing Dave's patch instead, can you please check that it works OK
for you?
Tony
prev parent reply other threads:[~2008-03-18 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 19:50 [PATCH 0/2] General compile fixes Felipe Balbi
2008-03-17 19:50 ` [PATCH] DSP: Fix dsp_common.c compile breakage Felipe Balbi
2008-03-17 19:50 ` [PATCH] USB: GADGET: Fix compile breakage on omap_udc.c Felipe Balbi
2008-03-18 9:19 ` Tony Lindgren
2008-03-18 9:18 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080318091852.GF20921@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.