All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dale Farnsworth <dale@farnsworth.org>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: netdev@vger.kernel.org, Nicolas Pitre <nico@marvell.com>,
	Tzachi Perelstein <tzachi@marvell.com>,
	Saeed Bishara <saeed@marvell.com>
Subject: Re: [PATCH 0/7][MV643XX_ETH] various cleanups
Date: Tue, 18 Mar 2008 09:14:06 -0700	[thread overview]
Message-ID: <20080318161406.GA27913@farnsworth.org> (raw)
In-Reply-To: <20080317191546.GA17828@xi.wantstofly.org>

On Mon, Mar 17, 2008 at 08:15:46PM +0100, Lennert Buytenhek wrote:
> Hi all,
> 
> This patch series performs various cleanups of mv643xx_eth, and moves
> it into the direction of being able to be instantiated multiple times
> -- which is currently not possible due to the driver using static
> variables, identifying ports by their port index within the single
> supported instance[*] instead of a pointer to a describing structure,
> and such.
> 
> The goal of multiple instantiation isn't achieved yet by this patch
> set, since it requires some changes in how mv643xx_eth platform
> devices are instantiated which in turn requires some changes in
> arch/{ppc,powerpc} which haven't been fully sorted out and agreed
> upon yet -- but this patch set is a step in the general direction,
> and the maintainer has informally ACKed these patches previously
> (in private mail), so I'm seeking wider feedback on them now.

Hi Lennert,

I'm happy with the end result, but the current patch series will
not build after patches 1-3 are applied.  Please reorder your
code changes so the result will be git-bisectable.

-Dale

  reply	other threads:[~2008-03-20  6:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17 19:15 [PATCH 0/7][MV643XX_ETH] various cleanups Lennert Buytenhek
2008-03-18 16:14 ` Dale Farnsworth [this message]
2008-03-18 16:40   ` Lennert Buytenhek
2008-03-18 22:03     ` Dale Farnsworth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080318161406.GA27913@farnsworth.org \
    --to=dale@farnsworth.org \
    --cc=buytenh@wantstofly.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico@marvell.com \
    --cc=saeed@marvell.com \
    --cc=tzachi@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.