From: Oleg Nesterov <oleg@tv-sign.ru>
To: serge@hallyn.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Atsushi Tsuji <a-tsuji@bk.jp.nec.com>,
Roland McGrath <roland@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Davide Libenzi <davidel@xmailserver.org>,
Ingo Molnar <mingo@elte.hu>, Jiri Kosina <jkosina@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
Pavel Emelyanov <xemul@openvz.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] signals: check_kill_permission: check session under tasklist_lock
Date: Tue, 18 Mar 2008 23:17:25 +0300 [thread overview]
Message-ID: <20080318201725.GA92@tv-sign.ru> (raw)
In-Reply-To: <20080318200304.GA23859@vino.hallyn.com>
On 03/18, serge@hallyn.com wrote:
>
> Quoting Oleg Nesterov (oleg@tv-sign.ru):
> > --- 25/security/commoncap.c~CKP_TAKE_TASKLIST 2008-03-18 17:07:02.000000000 +0300
> > +++ 25/security/commoncap.c 2008-03-18 17:21:10.000000000 +0300
> > @@ -552,10 +552,6 @@ int cap_task_kill(struct task_struct *p,
> > if (p->uid == current->uid)
> > return 0;
> >
> > - /* sigcont is permitted within same session */
> > - if (sig == SIGCONT && (task_session_nr(current) == task_session_nr(p)))
> > - return 0;
> > -
> > if (secid)
> > /*
> > * Signal sent as a particular user.
>
> Note that cap_task_kill() should be gone anyway. What tree were you
> basing this on?
Ah. I realy hoped that cap_task_kill() was already killed. And I googled
this patch: http://marc.info/?l=linux-kernel&m=120422062515386
But I checked 2.6.25-rc5-mm1.bz2, it is still here. And I didn't find
anything related in http://userweb.kernel.org/~akpm/mmotm/. I even checked
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;f=security/commoncap.c
So, is it still here or killed? If it is dead - great ;)
Oleg.
next prev parent reply other threads:[~2008-03-19 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 18:57 [RFC,PATCH 2/2] kill_pid_info: don't take now unneeded tasklist_lock Oleg Nesterov
2008-03-06 10:56 ` Roland McGrath
2008-03-17 11:30 ` Atsushi Tsuji
2008-03-17 17:01 ` Oleg Nesterov
2008-03-18 14:44 ` [PATCH] signals: check_kill_permission: check session under tasklist_lock Oleg Nesterov
2008-03-18 20:03 ` serge
2008-03-18 20:17 ` Oleg Nesterov [this message]
2008-03-18 23:14 ` serge
2008-03-19 2:19 ` Atsushi Tsuji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080318201725.GA92@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=a-tsuji@bk.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=ebiederm@xmission.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=serge@hallyn.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.