From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jc0t5-0005Cc-6e for mharc-grub-devel@gnu.org; Wed, 19 Mar 2008 12:11:35 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jc0t2-0005CL-5Q for grub-devel@gnu.org; Wed, 19 Mar 2008 12:11:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jc0sz-0005Bb-M7 for grub-devel@gnu.org; Wed, 19 Mar 2008 12:11:30 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jc0sz-0005BX-Em for grub-devel@gnu.org; Wed, 19 Mar 2008 12:11:29 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jc0sz-0000Do-9m for grub-devel@gnu.org; Wed, 19 Mar 2008 12:11:29 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Jc0su-0008HH-9r; Wed, 19 Mar 2008 17:11:27 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1Jc0rx-0001Ie-Dd; Wed, 19 Mar 2008 17:10:25 +0100 Date: Wed, 19 Mar 2008 17:10:25 +0100 From: Robert Millan To: Fabian Greffrath Message-ID: <20080319161025.GA4572@thorin> References: <20080228101000.GA350@thorin> <47C68CBD.8020601@leat.rub.de> <20080228104156.GJ350@thorin> <47C69F1D.9090405@leat.rub.de> <20080228170738.GB26926@thorin> <47C7C349.6040303@leat.rub.de> <20080303210656.GD22431@thorin> <47CE91CC.5010603@leat.rub.de> <20080319143815.GA885@thorin> <47E12ED2.2000302@leat.rub.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47E12ED2.2000302@leat.rub.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: The development of GRUB 2 , "Yoshinori K. Okuji" Subject: Re: [NEW PATCH] os-prober output parser X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Mar 2008 16:11:33 -0000 On Wed, Mar 19, 2008 at 04:18:42PM +0100, Fabian Greffrath wrote: > >When run in the console it makes Linux spit a truckload of information > >about > >filesystem probing. Is there any way we could avoid this? > > I don't know why this happens since I allready divert stderr to > /dev/null in the os-prober call. Maybe this is a bug in os-prober itself. They're printed directly by Linux. No idea how to stop that, but I don't think this problem is a showstopper anyway (they're always printed to /dev/console). > >How do you prevent it from detecting your own partition? I didn't see any > >provisions for this. > > I don't have to. That's the way os-prober works. Ok. > >Whops. This tag (utf-8 stuff?) breaks the Linux shebang parser :-) > > Yes, sorry. I am forced to store the file on a Windows partition in > order to send it as an email attachment. Don't ask me about UTF8 and > Windows. ;) Argh.. :-) > >Can we avoid hardcoding their absolute path? > > Yes, via the 'which' command - as has been implemented in previous > versions of this script. But back then you had objections against it... I prefer which myself, but IIRC Okuji said this isn't as much portable. The alternative is to do it like grub-install: set $grub_setup dummy if test -f "$1"; then : else echo "$1: Not found." 1>&2 exit 1 fi which is very ugly if you ask me. Okuji, do you have any comments on this? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)