All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: Dan Williams <dcbw@redhat.com>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: convert RSSI to a direct command
Date: Wed, 19 Mar 2008 16:44:56 +0100	[thread overview]
Message-ID: <200803191644.57007.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <1205940431.4169.10.camel@localhost.localdomain>

> 1) We do need to fix the Ad-Hoc bits somehow, I guess that
> means periodically poking GET_RSSI when connected and
> averaging the result over the last 30 seconds, weighting
> recent results more

Okay for the periodically poking.

But we don't really need to average by ourselves, the GET_RSSI 
has an average weight parameter. We can store this in 
priv->avg_rssi and priv->avg_noise to re-use it later.


> 2) Use the windowed average for 'iwconfig'/SIOCGIWSTATS, the
> Ad-Hoc scan result, and scan results on the current channel

The patch as it is doesn't use any averaging 
for 'iwconfig'/SIOCGIWSTATS, it just uses the value from 
GET_RSSI, which is from the beacons of the associated AP. 
Together with the changed (simplified) quality calculation I now 
get a fast-enought changing display for a moving station. And 
it's no longer jerky as it used to be, despite the missing 
averaging. This non-jerkyness might come from the fact that RXPD 
packets aren't taken into account anymore. So I'm not sure if 
any averaging here will be an improvement, at least not for 
moving stations. It might be nicer for an office PC, thought.

I don't have a problem with priv->avg_noise for scan results and 
no problem at all what you want to do with AD HOC :-)


>
> 3) Use the default noise floor for all channels not the
> associated channel
>
> If you like, I'm interested in doing this.
>
> Dan



  reply	other threads:[~2008-03-19 19:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 12:42 [PATCH] libertas: convert RSSI to a direct command Holger Schurig
2008-03-19 14:31 ` Dan Williams
2008-03-19 15:14   ` Holger Schurig
2008-03-19 15:27     ` Dan Williams
2008-03-19 15:44       ` Holger Schurig [this message]
2008-03-26  9:21       ` Holger Schurig
2008-03-19 16:36   ` Holger Schurig
2008-03-19 16:40   ` [PATCH, take 2] " Holger Schurig
2008-03-19 16:52     ` Holger Schurig
  -- strict thread matches above, loose matches on Subject: below --
2008-03-13  9:59 [PATCH] " Holger Schurig
2008-03-13 14:50 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803191644.57007.hs4233@mail.mn-solutions.de \
    --to=hs4233@mail.mn-solutions.de \
    --cc=dcbw@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.