From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: [PATCH] ioemu: Initialize ioport_opaque to zero Date: Wed, 19 Mar 2008 17:07:03 +0000 Message-ID: <20080319170703.GF9372@implementation.uk.xensource.com> References: <20080319170259.GE9372@implementation.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20080319170259.GE9372@implementation.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Samuel Thibault, le Wed 19 Mar 2008 17:02:59 +0000, a écrit : > ioemu: Initialize ioport_opaque to zero > since register_ioport_read requires it. Mmm, actually ioport_read/write_table need it too: ioemu: Initialize ioport_opaque, ioport_read/write_table to zero Signed-off-by: Samuel Thibault diff -r b3c8dcb98543 tools/ioemu/vl.c --- a/tools/ioemu/vl.c Wed Mar 19 16:25:52 2008 +0000 +++ b/tools/ioemu/vl.c Wed Mar 19 17:05:03 2008 +0000 @@ -281,9 +281,9 @@ void default_ioport_writel(void *opaque, void init_ioports(void) { - ioport_opaque = malloc(MAX_IOPORTS * sizeof(*ioport_opaque)); - ioport_read_table = malloc(3 * MAX_IOPORTS * sizeof(**ioport_read_table)); - ioport_write_table = malloc(3 * MAX_IOPORTS * sizeof(**ioport_write_table)); + ioport_opaque = calloc(MAX_IOPORTS, sizeof(*ioport_opaque)); + ioport_read_table = calloc(3 * MAX_IOPORTS, sizeof(**ioport_read_table)); + ioport_write_table = calloc(3 * MAX_IOPORTS, sizeof(**ioport_write_table)); } /* size is the word size in byte */