From: Ingo Molnar <mingo@elte.hu>
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
tglx@linutronix.de, ak@suse.de
Subject: Re: [PATCH] build fix for smp
Date: Wed, 19 Mar 2008 20:52:17 +0100 [thread overview]
Message-ID: <20080319195217.GA20762@elte.hu> (raw)
In-Reply-To: <12059466674071-git-send-email-gcosta@redhat.com>
* Glauber de Oliveira Costa <gcosta@redhat.com> wrote:
> +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_BIOS_REBOOT)
> if (reboot_force)
> return;
> +#endif
please solve it slightly differently: introduce a uniformly usable
reboot_force flag, that will always default to the constant of 1 if
!X86_64 && !X86_BIOS_REBOOT. That makes the code cleaner - and not the
least i can also merge the fix earlier in the series, without having to
redo the big smp.c movement patch :-)
Ingo
next prev parent reply other threads:[~2008-03-19 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 17:11 [PATCH] build fix for smp Glauber de Oliveira Costa
2008-03-19 19:52 ` Ingo Molnar [this message]
2008-04-28 7:52 ` Sergio Luis
2008-04-28 8:50 ` Ingo Molnar
2008-04-28 9:01 ` Sergio Luis
2008-04-28 14:16 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080319195217.GA20762@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.