From: akepner@sgi.com
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Jes Sorensen <jes@sgi.com>, Roland Dreier <rdreier@cisco.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
David Miller <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Grant Grundler <grundler@parisc-linux.org>,
Michael Ellerman <michael@ellerman.id.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4 v4] dma: dma_{un}map_{single|sg}_attrs() interface
Date: Wed, 19 Mar 2008 17:29:28 -0700 [thread overview]
Message-ID: <20080320002928.GL1843@sgi.com> (raw)
In-Reply-To: <20080313082754.3da94420.randy.dunlap@oracle.com>
On Thu, Mar 13, 2008 at 08:27:54AM -0700, Randy Dunlap wrote:
Thanks for looking at this. A new patchset is on the way.
> On Thu, 13 Mar 2008 01:41:06 -0700 Andrew Morton wrote:
>
> > > +#ifdef ARCH_USES_DMA_ATTRS
> >
> > There is no precedent for ARCH_USES_*.
> >
> > There is a little bit of precedent for ARCH_HAVE_*
> >
> > There is lots of precendence for ARCH_HAS_*.
> >
> > We don't like ARCH_HAS_* anyway ;) What can we do to get rid of this?
> > Ideally, make it available on all architectures at zero cost to those which
> > don't need it. If that is impractical (why?) then it is preferable to do
> > this in Kconfig.
>
> Sam has been pushing HAVE_* and even added that to
> Documentation/kbuild/kconfig-language.txt.
OK, changed it to CONFIG_HAVE_DMA_ATTRS.
>
> > > +/*
> > > + * dma_set_attr - set a specific attribute
> > > + * may be called with a null attrs
> > > + */
>
> Use kernel-doc notation?
Done.
--
Arthur
(503) 234 4671
next prev parent reply other threads:[~2008-03-20 0:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 4:00 [PATCH 0/4 v4] dma: dma_{un}map_{single|sg}_attrs() interface akepner
2008-03-13 8:41 ` Andrew Morton
2008-03-13 15:27 ` Randy Dunlap
2008-03-20 0:29 ` akepner [this message]
2008-03-20 0:26 ` akepner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080320002928.GL1843@sgi.com \
--to=akepner@sgi.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.