From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JcI8k-0006pc-UW for mharc-grub-devel@gnu.org; Thu, 20 Mar 2008 06:36:55 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JcI8h-0006mS-NX for grub-devel@gnu.org; Thu, 20 Mar 2008 06:36:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JcI8e-0006is-M3 for grub-devel@gnu.org; Thu, 20 Mar 2008 06:36:50 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JcI8e-0006iX-Dr for grub-devel@gnu.org; Thu, 20 Mar 2008 06:36:48 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JcI8d-0002aO-Vn for grub-devel@gnu.org; Thu, 20 Mar 2008 06:36:48 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JcI8Z-0001VS-To; Thu, 20 Mar 2008 11:36:47 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JcI8I-0002iR-Mr; Thu, 20 Mar 2008 11:36:26 +0100 Date: Thu, 20 Mar 2008 11:36:26 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080320103626.GA10347@thorin> References: <20080228104156.GJ350@thorin> <47C69F1D.9090405@leat.rub.de> <20080228170738.GB26926@thorin> <47C7C349.6040303@leat.rub.de> <20080303210656.GD22431@thorin> <47CE91CC.5010603@leat.rub.de> <20080319143815.GA885@thorin> <47E12ED2.2000302@leat.rub.de> <20080319161025.GA4572@thorin> <47E2363B.3020509@leat.rub.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47E2363B.3020509@leat.rub.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: "Yoshinori K. Okuji" Subject: Re: [NEW PATCH] os-prober output parser X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Mar 2008 10:36:52 -0000 On Thu, Mar 20, 2008 at 11:02:35AM +0100, Fabian Greffrath wrote: > Robert Millan schrieb: > >which is very ugly if you ask me. Okuji, do you have any comments on this? > > Apart from this issue, is the script allright? Also, you can remove this check now: if [ -z "`grub-probe --help 2> /dev/null | grep '\-d,\ \-\-device'`" ] ; then # grub-probe does not support '--device' option yet (introduced in 1.96+20080228) exit 0 fi and please include a ChangeLog entry. As far as I'm concerned, there's nothing else missing. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)