From: Rob Landley <rob@landley.net>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Corrections to Documentation/rbtree.txt
Date: Thu, 20 Mar 2008 13:39:18 -0500 [thread overview]
Message-ID: <200803201339.18618.rob@landley.net> (raw)
In-Reply-To: <47E282F5.6090703@mev.co.uk>
On Thursday 20 March 2008 10:29:57 Ian Abbott wrote:
> From: Ian Abbott <abbotti@mev.co.uk>
>
> The description of the rb_entry() macro in Documentation/rbtree.txt seems
> incorrect. This patch improves it (hopefully). Also I changed the example
> code to call the previous 'my_search()' example instead of an undefined
> 'mysearch()'.
I have no objection to the patch (and the my_search thing seems like an
obvious typo), but is there a reason to prefer rb_entry() rather than
container_of()? If so, the rationale might be a good thing to add to the
documentation...
Rob
--
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
next prev parent reply other threads:[~2008-03-20 18:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 15:29 [PATCH] Corrections to Documentation/rbtree.txt Ian Abbott
2008-03-20 18:39 ` Rob Landley [this message]
2008-03-25 11:02 ` Ian Abbott
2008-03-25 18:24 ` Rob Landley
2008-03-26 14:09 ` Ian Abbott
2008-03-25 11:29 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803201339.18618.rob@landley.net \
--to=rob@landley.net \
--cc=abbotti@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.