From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD Date: Thu, 20 Mar 2008 15:33:04 -0700 Message-ID: <20080320153304.cdc1817d.akpm@linux-foundation.org> References: <12059526271941-git-send-email-yorksun@freescale.com> <12059526274026-git-send-email-yorksun@freescale.com> <12059526271964-git-send-email-yorksun@freescale.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JcTKU-0005q7-EY for linux-fbdev-devel@lists.sourceforge.net; Thu, 20 Mar 2008 15:33:46 -0700 Received: from smtp1.linux-foundation.org ([140.211.169.13]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1JcTKU-0005tw-6V for linux-fbdev-devel@lists.sourceforge.net; Thu, 20 Mar 2008 15:33:46 -0700 In-Reply-To: <12059526271964-git-send-email-yorksun@freescale.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, galak@kernel.crashing.org, linuxppc-dev@ozlabs.org, Andy Whitcroft , yorksun@freescale.com On Wed, 19 Mar 2008 13:50:27 -0500 York Sun wrote: > Add platform code to support Freescale DIU. The platform code includes > framebuffer memory allocation, pixel format, monitor port, etc. > > ... > > +unsigned int mpc8610hpcd_get_pixel_format > + (unsigned int bits_per_pixel, int monitor_port) Again, please do unsigned int mpc8610hpcd_get_pixel_format(unsigned int bits_per_pixel, int monitor_port) (and anywhere else where this was done) > +int __init preallocate_diu_videomemory(void); Nope, please don't put extern declarations in .c files. Find a suitable header for it - one which is included by the defining file and by all users of the symbol. Andy, checkpatch missed this. > } > #endif > + ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "smtp.linux-foundation.org", Issuer "CA Cert Signing Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 93734DDF04 for ; Fri, 21 Mar 2008 09:33:49 +1100 (EST) Date: Thu, 20 Mar 2008 15:33:04 -0700 From: Andrew Morton To: York Sun Subject: Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD Message-Id: <20080320153304.cdc1817d.akpm@linux-foundation.org> In-Reply-To: <12059526271964-git-send-email-yorksun@freescale.com> References: <12059526271941-git-send-email-yorksun@freescale.com> <12059526274026-git-send-email-yorksun@freescale.com> <12059526271964-git-send-email-yorksun@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, yorksun@freescale.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 19 Mar 2008 13:50:27 -0500 York Sun wrote: > Add platform code to support Freescale DIU. The platform code includes > framebuffer memory allocation, pixel format, monitor port, etc. > > ... > > +unsigned int mpc8610hpcd_get_pixel_format > + (unsigned int bits_per_pixel, int monitor_port) Again, please do unsigned int mpc8610hpcd_get_pixel_format(unsigned int bits_per_pixel, int monitor_port) (and anywhere else where this was done) > +int __init preallocate_diu_videomemory(void); Nope, please don't put extern declarations in .c files. Find a suitable header for it - one which is included by the defining file and by all users of the symbol. Andy, checkpatch missed this. > } > #endif > + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759134AbYCTWeN (ORCPT ); Thu, 20 Mar 2008 18:34:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757737AbYCTWd6 (ORCPT ); Thu, 20 Mar 2008 18:33:58 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:59949 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757729AbYCTWd6 (ORCPT ); Thu, 20 Mar 2008 18:33:58 -0400 Date: Thu, 20 Mar 2008 15:33:04 -0700 From: Andrew Morton To: York Sun Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, galak@kernel.crashing.org, linux-fbdev-devel@lists.sourceforge.net, yorksun@freescale.com, Andy Whitcroft Subject: Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD Message-Id: <20080320153304.cdc1817d.akpm@linux-foundation.org> In-Reply-To: <12059526271964-git-send-email-yorksun@freescale.com> References: <12059526271941-git-send-email-yorksun@freescale.com> <12059526274026-git-send-email-yorksun@freescale.com> <12059526271964-git-send-email-yorksun@freescale.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Mar 2008 13:50:27 -0500 York Sun wrote: > Add platform code to support Freescale DIU. The platform code includes > framebuffer memory allocation, pixel format, monitor port, etc. > > ... > > +unsigned int mpc8610hpcd_get_pixel_format > + (unsigned int bits_per_pixel, int monitor_port) Again, please do unsigned int mpc8610hpcd_get_pixel_format(unsigned int bits_per_pixel, int monitor_port) (and anywhere else where this was done) > +int __init preallocate_diu_videomemory(void); Nope, please don't put extern declarations in .c files. Find a suitable header for it - one which is included by the defining file and by all users of the symbol. Andy, checkpatch missed this. > } > #endif > +