From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH] socket: SOCK_DEBUG type checking
Date: Fri, 21 Mar 2008 07:51:32 -0700 [thread overview]
Message-ID: <20080321075132.2fe4ac23@extreme> (raw)
Use the inline trick (same as pr_debug) to get checking
of debug statements even if no code is generated.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/include/net/sock.h 2008-03-20 20:25:04.000000000 -0700
+++ b/include/net/sock.h 2008-03-20 20:28:48.000000000 -0700
@@ -70,7 +70,11 @@
#define SOCK_DEBUG(sk, msg...) do { if ((sk) && sock_flag((sk), SOCK_DBG)) \
printk(KERN_DEBUG msg); } while (0)
#else
-#define SOCK_DEBUG(sk, msg...) do { } while (0)
+/* Validate arguments and do nothing */
+static void inline int __attribute__ ((format (printf, 2, 3)))
+SOCK_DEBUG(struct sock *sk, const char *msg, ...)
+{
+}
#endif
/* This is the per-socket lock. The spinlock provides a synchronization
next reply other threads:[~2008-03-21 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 14:51 Stephen Hemminger [this message]
2008-03-21 22:56 ` [PATCH] socket: SOCK_DEBUG type checking David Miller
2008-03-22 0:17 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321075132.2fe4ac23@extreme \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.