From: Jean Delvare <khali@linux-fr.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Michael Buesch <mb@bu3sch.de>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
David Brownell <david-b@pacbell.net>,
Richard Purdie <rpurdie@rpsys.net>,
<linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: use of preempt_count instead of in_atomic() at leds-gpio.c
Date: Fri, 21 Mar 2008 10:53:11 +0100 [thread overview]
Message-ID: <20080321105311.1a55cc0f@hyperion.delvare> (raw)
In-Reply-To: <20080320201723.b87b3732.akpm@linux-foundation.org>
On Thu, 20 Mar 2008 20:17:23 -0700, Andrew Morton wrote:
> in_atomic() is for core kernel use only. (...)
Then why is it made available to drivers through <linux/hardirq.h>? If
it's such a dangerous macro to call from drivers, it shouldn't be made
available, or at the very least there should be a big fat warning in
<linux/hardirq.h> that drivers aren't supposed to use it. This would
have avoided the 23 uses cases in drivers we have right now.
--
Jean Delvare
next prev parent reply other threads:[~2008-03-21 9:53 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 18:43 use of preempt_count instead of in_atomic() at leds-gpio.c Henrique de Moraes Holschuh
2008-03-16 19:46 ` David Brownell
2008-03-18 7:14 ` Andrew Morton
2008-03-18 19:06 ` David Brownell
2008-03-18 20:07 ` Andrew Morton
2008-03-20 22:56 ` Henrique de Moraes Holschuh
2008-03-20 23:47 ` Andrew Morton
2008-03-21 0:36 ` Henrique de Moraes Holschuh
2008-03-21 1:08 ` Andrew Morton
2008-03-21 1:31 ` Alan Stern
2008-03-21 1:31 ` Alan Stern
2008-03-21 1:36 ` Michael Buesch
2008-03-21 1:36 ` Michael Buesch
2008-03-21 2:27 ` Andrew Morton
2008-03-21 2:27 ` Andrew Morton
2008-03-21 3:07 ` Alan Stern
2008-03-21 3:07 ` Alan Stern
2008-03-21 3:17 ` Andrew Morton
2008-03-21 3:17 ` Andrew Morton
2008-03-21 9:53 ` Jean Delvare [this message]
2008-03-21 17:37 ` Andrew Morton
2008-03-21 18:05 ` Alan Stern
2008-03-24 19:34 ` Jonathan Corbet
2008-03-24 19:42 ` Andrew Morton
2008-03-24 19:53 ` Jonathan Corbet
2008-03-25 8:52 ` Junio C Hamano
2008-03-25 10:39 ` Jean Delvare
2008-03-25 13:44 ` Jonathan Corbet
2008-03-25 23:20 ` David Brownell
2008-03-26 14:28 ` Alan Stern
2008-03-26 16:17 ` Henrique de Moraes Holschuh
2008-03-26 16:46 ` Richard Purdie
2008-03-27 18:51 ` David Brownell
2008-03-21 15:11 ` Tetsuo Handa
2008-03-21 16:54 ` Stefan Richter
2008-03-21 17:02 ` Stefan Richter
2008-03-23 5:53 ` Tetsuo Handa
2008-03-21 13:47 ` Heiko Carstens
2008-03-21 13:47 ` Heiko Carstens
2008-03-21 16:54 ` Greg KH
2008-03-21 16:54 ` Greg KH
2008-03-21 19:59 ` Andrew Morton
2008-03-21 19:59 ` Andrew Morton
2008-03-21 20:16 ` Michael Buesch
2008-03-21 20:16 ` Michael Buesch
2008-03-21 20:20 ` Michael Buesch
2008-03-21 20:20 ` Michael Buesch
2008-03-21 9:21 ` Stefan Richter
2008-03-21 9:21 ` Stefan Richter
2008-03-21 9:27 ` Stefan Richter
2008-03-21 9:27 ` Stefan Richter
2008-03-21 12:37 ` Henrique de Moraes Holschuh
2008-03-21 12:37 ` Henrique de Moraes Holschuh
2008-03-21 13:16 ` Stefan Richter
2008-03-22 11:29 ` Stefan Richter
2008-03-22 11:29 ` Stefan Richter
[not found] ` <20080320180802.426ad2d1.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-03-21 15:42 ` Use of in_atomic in i2c_transfer (Was: use of preempt_count instead of in_atomic() at leds-gpio.c) Jean Delvare
[not found] ` <20080321164235.26c95e17-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-21 16:00 ` Russell King - ARM Linux
2008-03-21 17:04 ` use of preempt_count instead of in_atomic() at leds-gpio.c David Brownell
2008-03-21 17:04 ` David Brownell
2008-03-21 17:04 ` David Brownell
2008-03-21 0:56 ` Richard Purdie
2008-03-21 2:10 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321105311.1a55cc0f@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=geert@linux-m68k.org \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=mingo@elte.hu \
--cc=rpurdie@rpsys.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.