* [PATCH] Fix sh_keysc double free
@ 2008-03-21 11:14 ` Magnus Damm
0 siblings, 0 replies; 4+ messages in thread
From: Magnus Damm @ 2008-03-21 11:14 UTC (permalink / raw)
To: linux-input; +Cc: Magnus Damm, lethal, dmitry.torokhov, akpm, linux-sh
Avoid double free situation from happening by removing input_free_device()
after input_unregister_device(). Suggested by Dmitry Torokhov.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
drivers/input/keyboard/sh_keysc.c | 1 -
1 file changed, 1 deletion(-)
--- 0001/drivers/input/keyboard/sh_keysc.c
+++ work/drivers/input/keyboard/sh_keysc.c 2008-03-21 10:58:20.000000000 +0900
@@ -238,7 +238,6 @@ static int __devexit sh_keysc_remove(str
input_unregister_device(priv->input);
free_irq(platform_get_irq(pdev, 0), pdev);
- input_free_device(priv->input);
iounmap(priv->iomem_base);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Fix sh_keysc double free
@ 2008-03-21 11:14 ` Magnus Damm
0 siblings, 0 replies; 4+ messages in thread
From: Magnus Damm @ 2008-03-21 11:14 UTC (permalink / raw)
To: linux-input; +Cc: Magnus Damm, lethal, dmitry.torokhov, akpm, linux-sh
Avoid double free situation from happening by removing input_free_device()
after input_unregister_device(). Suggested by Dmitry Torokhov.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
drivers/input/keyboard/sh_keysc.c | 1 -
1 file changed, 1 deletion(-)
--- 0001/drivers/input/keyboard/sh_keysc.c
+++ work/drivers/input/keyboard/sh_keysc.c 2008-03-21 10:58:20.000000000 +0900
@@ -238,7 +238,6 @@ static int __devexit sh_keysc_remove(str
input_unregister_device(priv->input);
free_irq(platform_get_irq(pdev, 0), pdev);
- input_free_device(priv->input);
iounmap(priv->iomem_base);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix sh_keysc double free
2008-03-21 11:14 ` Magnus Damm
@ 2008-03-24 6:13 ` Paul Mundt
-1 siblings, 0 replies; 4+ messages in thread
From: Paul Mundt @ 2008-03-24 6:13 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-input, dmitry.torokhov, akpm, linux-sh
On Fri, Mar 21, 2008 at 08:14:46PM +0900, Magnus Damm wrote:
> Avoid double free situation from happening by removing input_free_device()
> after input_unregister_device(). Suggested by Dmitry Torokhov.
>
> Signed-off-by: Magnus Damm <damm@igel.co.jp>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-03-24 6:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-21 11:14 [PATCH] Fix sh_keysc double free Magnus Damm
2008-03-21 11:14 ` Magnus Damm
2008-03-24 6:13 ` Paul Mundt
2008-03-24 6:13 ` Paul Mundt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.