All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alexander van Heukelum <heukelum@mailshack.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Alexander van Heukelum <heukelum@fastmail.fm>,
	Andi Kleen <andi@firstfloor.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Date: Fri, 21 Mar 2008 13:35:48 +0100	[thread overview]
Message-ID: <20080321123548.GL25225@elte.hu> (raw)
In-Reply-To: <20080315120442.GA21183@mailshack.com>


* Alexander van Heukelum <heukelum@mailshack.com> wrote:

> x86: merge the simple bitops and move them to bitops.h.
> 
> Some of those can be written in such a way that the same inline 
> assembly can be used to generate both 32 bit and 64 bit code.
> 
> For ffs and fls, x86_64 unconditionally used the cmov instruction and 
> i386 unconditionally used a conditional branch over a mov instruction. 
> In the current patch I chose to select the version based on the 
> availability of the cmov instruction instead. A small detail here is 
> that x86_64 did not previously set CONFIG_X86_CMOV=y.
> 
> Improved comments for ffs, ffz, fls and variations.

thanks Alexander, applied.

	Ingo

  reply	other threads:[~2008-03-21 12:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-12 20:01 [PATCH] x86: merge the simple bitops and move them to bitops.h Alexander van Heukelum
2008-03-14 18:07 ` Jeremy Fitzhardinge
2008-03-14 19:43   ` Alexander van Heukelum
2008-03-14 19:55     ` Andi Kleen
2008-03-14 21:33       ` Alexander van Heukelum
2008-03-14 21:42         ` Andi Kleen
2008-03-14 22:01           ` Alexander van Heukelum
2008-03-14 22:18             ` Andi Kleen
2008-03-15 17:54               ` Alexander van Heukelum
2008-03-15 19:19         ` K8, EFFICEON and CORE2 support the cmovxx instructions Alexander van Heukelum
2008-03-15 20:18           ` H. Peter Anvin
2008-03-15 21:06             ` Alexander van Heukelum
2008-03-15 21:11               ` Willy Tarreau
2008-03-16 13:16                 ` [PATCH] x86: K8, GEODE_LX, CRUSOE, " Alexander van Heukelum
2008-03-21 12:38                   ` Ingo Molnar
2008-03-14 20:35     ` [PATCH v2] x86: merge the simple bitops and move them to bitops.h Alexander van Heukelum
2008-03-14 23:30       ` Randy Dunlap
2008-03-15 12:04         ` [PATCH v3] " Alexander van Heukelum
2008-03-21 12:35           ` Ingo Molnar [this message]
2008-03-14 21:15     ` [PATCH] " Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080321123548.GL25225@elte.hu \
    --to=mingo@elte.hu \
    --cc=andi@firstfloor.org \
    --cc=heukelum@fastmail.fm \
    --cc=heukelum@mailshack.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.