From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
To: peter fuerst <post@pfrst.de>
Cc: linux-scsi@vger.kernel.org, linux-mips@linux-mips.org,
ralf@linux-mips.org, James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH] WD33C93: let platform stub override no_sync/fast/dma_mode
Date: Sat, 22 Mar 2008 00:04:24 +0100 [thread overview]
Message-ID: <20080321230424.GA31455@alpha.franken.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0803212302190.564@Indigo2.Peter>
On Fri, Mar 21, 2008 at 11:20:07PM +0100, peter fuerst wrote:
>
> the code-sequence
>
> wd33c93_init(...
> if (hdata->wh.no_sync == 0xff)
> hdata->wh.no_sync = 0;
>
> was put/kept there intentionally - in this very order - to enable
> "nosync" from the command-line!
this hack is IMHO no longer needed. If the user wants to override no_sync
via kernel command line, it works as before. If the user doesn't no_sync
will be 0 (now set in sgiwd93.c before calling wd33c93_init()) and the
driver will try to do sync transfers for all devices. It works like before.
Or did I miss something ?
Thomas
--
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2008-03-21 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 21:25 [PATCH] WD33C93: let platform stub override no_sync/fast/dma_mode Thomas Bogendoerfer
2008-03-21 22:12 ` Ralf Baechle
2008-03-21 22:20 ` peter fuerst
2008-03-21 22:28 ` peter fuerst
2008-03-21 23:04 ` Thomas Bogendoerfer [this message]
2008-03-21 23:45 ` peter fuerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321230424.GA31455@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-scsi@vger.kernel.org \
--cc=post@pfrst.de \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.