From: Jens Axboe <jens.axboe@oracle.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] cdrom: use list_head for cdrom_device_info list
Date: Sat, 22 Mar 2008 13:55:35 +0100 [thread overview]
Message-ID: <20080322125535.GE15355@kernel.dk> (raw)
In-Reply-To: <20080322031248.GD3665@APFDCB5C>
On Sat, Mar 22 2008, Akinobu Mita wrote:
> Use list_head for cdrom_device_info list instead of opencoded
> singly list handling.
Looks good, but you don't seem to be initializing ->list anywhere. Did
you test this?
I'd suggest just adding an INIT_LIST_HEAD() before the list_add() in
register_cdrom()
You also seem to remove the !cdi check, which would be an unrelated
change.
--
Jens Axboe
next prev parent reply other threads:[~2008-03-22 12:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-22 3:09 [PATCH 1/5] cdrom: remove ifdef CONFIG_SYSCTL Akinobu Mita
2008-03-22 3:10 ` [PATCH 2/5] cdrom: cleanup hardcoded error-code Akinobu Mita
2008-03-22 3:12 ` [PATCH 3/5] cdrom: protect cdrom_device_info list by mutex Akinobu Mita
2008-03-22 3:12 ` [PATCH 4/5] cdrom: use list_head for cdrom_device_info list Akinobu Mita
2008-03-22 3:14 ` [PATCH 5/5] cdrom: make unregister_cdrom() return void Akinobu Mita
2008-03-22 12:57 ` Jens Axboe
2008-03-22 15:45 ` Borislav Petkov
2008-03-22 16:43 ` Adrian McMenamin
2008-03-22 12:55 ` Jens Axboe [this message]
2008-03-22 12:56 ` [PATCH 4/5] cdrom: use list_head for cdrom_device_info list Jens Axboe
2008-03-22 15:10 ` Akinobu Mita
2008-03-22 17:57 ` Christoph Hellwig
2008-03-25 19:04 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080322125535.GE15355@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akinobu.mita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.