From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: mingo@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [patch 0/4] x86 - relocate_kernel cleanup
Date: Sun, 23 Mar 2008 14:10:17 +0300 [thread overview]
Message-ID: <20080323111017.GA7612@cvg> (raw)
In-Reply-To: <47E577B9.1010403@zytor.com>
[H. Peter Anvin - Sat, Mar 22, 2008 at 02:18:49PM -0700]
> H. Peter Anvin wrote:
>> gorcunov@gmail.com wrote:
>>> The main purpose of this patches is to eliminate numeric constant and
>>> use predefined macroses. Please review. I've tested 64bit version on
>>> object level - it remains the same. Any comments are welcome.
>> Looks good. Since you're doing work in this realm, you may also want to
>> replace the old TF_MASK etc macros with X86_EFLAGS_TF etc.
>
> That wasn't meant to be a comment specific to the relocate_kernel stuff,
> incidentally.
>
> -hpa
>
You know, Peter, I'm a bit scared that these flags are in number
of files and could break others queued patches...
- Cyrill -
next prev parent reply other threads:[~2008-03-23 11:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-22 21:00 [patch 0/4] x86 - relocate_kernel cleanup gorcunov
2008-03-22 21:00 ` [patch 1/4] x86: relocate_kernel_32.S - clear register in more elegant way gorcunov
2008-03-22 21:00 ` [patch 2/4] x86: relocate_kernel - use PAGE_SIZE instead of numeric constant gorcunov
2008-03-22 21:00 ` [patch 3/4] x86: relocate_kernel - use predefined macroses for processor state gorcunov
2008-03-22 21:00 ` [patch 4/4] x86: relocate_kernel - use predefined macroses for page attributes gorcunov
2008-03-22 21:14 ` [patch 0/4] x86 - relocate_kernel cleanup H. Peter Anvin
2008-03-22 21:18 ` H. Peter Anvin
2008-03-22 21:38 ` Cyrill Gorcunov
2008-03-23 11:10 ` Cyrill Gorcunov [this message]
2008-03-25 15:57 ` Ingo Molnar
2008-03-25 17:34 ` Cyrill Gorcunov
2008-03-25 15:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080323111017.GA7612@cvg \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.