From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760954AbYCWLZm (ORCPT ); Sun, 23 Mar 2008 07:25:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755785AbYCWLZc (ORCPT ); Sun, 23 Mar 2008 07:25:32 -0400 Received: from one.firstfloor.org ([213.235.205.2]:38496 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755825AbYCWLZc (ORCPT ); Sun, 23 Mar 2008 07:25:32 -0400 Date: Sun, 23 Mar 2008 12:28:29 +0100 From: Andi Kleen To: KOSAKI Motohiro Cc: Andi Kleen , linux-kernel@vger.kernel.org, pj@sgi.com, linux-mm@kvack.org, nickpiggin@yahoo.com.au Subject: Re: [PATCH] [2/18] Add basic support for more than one hstate in hugetlbfs Message-ID: <20080323112829.GA1619@one.firstfloor.org> References: <20080317258.659191058@firstfloor.org> <20080317015815.D43991B41E0@basil.firstfloor.org> <20080323193340.B31D.KOSAKI.MOTOHIRO@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080323193340.B31D.KOSAKI.MOTOHIRO@jp.fujitsu.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > this function is called once by one boot parameter, right? > if so, this function cause panic when stupid user write many > hugepagesz boot parameter. A later patch fixes that up by looking up the hstate explicitely. Also it is bisect safe because the callers are only added later. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sun, 23 Mar 2008 12:28:29 +0100 From: Andi Kleen Subject: Re: [PATCH] [2/18] Add basic support for more than one hstate in hugetlbfs Message-ID: <20080323112829.GA1619@one.firstfloor.org> References: <20080317258.659191058@firstfloor.org> <20080317015815.D43991B41E0@basil.firstfloor.org> <20080323193340.B31D.KOSAKI.MOTOHIRO@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080323193340.B31D.KOSAKI.MOTOHIRO@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org Return-Path: To: KOSAKI Motohiro Cc: Andi Kleen , linux-kernel@vger.kernel.org, pj@sgi.com, linux-mm@kvack.org, nickpiggin@yahoo.com.au List-ID: > this function is called once by one boot parameter, right? > if so, this function cause panic when stupid user write many > hugepagesz boot parameter. A later patch fixes that up by looking up the hstate explicitely. Also it is bisect safe because the callers are only added later. -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org