Re: [PATCH 1/8] New driver "sfc" for Solarstorm SFC4000 controller (try #8)

[Ben Hutchings <bhutchings@solarflare.com>]

David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Wed, 12 Mar 2008 01:22:48 +0000
> 
> > +static void efx_link_status_changed(struct efx_nic *efx)
> > +{
> > +	unsigned long flags __attribute__ ((unused));
> 
> Please just delete this variable, it really is never
> used not matter what the build configuration.

These are already gone from our internal version, as my colleague Steve
Hodgson also spotted that they are now unused.
> 
> > +
> > +		if (rss_cpus == 0) {
> > +#ifdef topology_core_siblings
> > +			cpumask_t core_mask;
> > +			int cpu;
> > +
> > +			cpus_clear(core_mask);
> > +			efx->rss_queues = 0;
> > +			for_each_online_cpu(cpu) {
> > +				if (!cpu_isset(cpu, core_mask)) {
> > +					++efx->rss_queues;
> > +					cpus_or(core_mask, core_mask,
> > +						topology_core_siblings(cpu));
> > +				}
> > +			}
> > +#else
> > +			efx->rss_queues = num_online_cpus();
> > +#endif
> 
> Please don't test feature availability this way.
> 
> Either use the proper CONFIG_* option ifdef.

The macro is defined for some architectures and not for others, and does
not depend on config options.  See Documentation/cputopology.txt.

> > +/* Allocate the NAPI dev's.
> > + * Called after we know how many channels there are.
> > + */
> > +static int efx_init_napi(struct efx_nic *efx)
> > +{
> > +	struct efx_channel *channel;
> > +	int rc;
> > +
> > +	/* Allocate the NAPI dev for the port */
> > +	efx->net_dev = alloc_etherdev(0);
> > +	if (!efx->net_dev) {
> > +		rc = -ENOMEM;
> > +		goto err;
> > +	}
> > +	efx->net_dev->priv = efx;
> > +	efx->mii.dev = efx->net_dev;
> 
> Please use alloc_etherdev() how is was designed, by
> specifying sizeof(struct efx_nic) as the size argument
> and that way your private area gets setup transparently
> and none of these explicit assignments are necessary.

OK.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.