From: Len Brown <lenb@kernel.org>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/2] ACPI: EC: Use default setup handler
Date: Mon, 24 Mar 2008 20:52:51 -0400 [thread overview]
Message-ID: <200803242052.51543.lenb@kernel.org> (raw)
In-Reply-To: <20080324202228.5055.11326.stgit@thinkpad.local>
1-2 addded to acpi-test
thanks,
-Len
On Monday 24 March 2008, Alexey Starikovskiy wrote:
> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
> ---
>
> drivers/acpi/ec.c | 16 +---------------
> 1 files changed, 1 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index f0e8216..167af37 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -533,20 +533,6 @@ static void do_ec_poll(struct work_struct *work)
> -------------------------------------------------------------------------- */
>
> static acpi_status
> -acpi_ec_space_setup(acpi_handle region_handle,
> - u32 function, void *handler_context, void **return_context)
> -{
> - /*
> - * The EC object is in the handler context and is needed
> - * when calling the acpi_ec_space_handler.
> - */
> - *return_context = (function != ACPI_REGION_DEACTIVATE) ?
> - handler_context : NULL;
> -
> - return AE_OK;
> -}
> -
> -static acpi_status
> acpi_ec_space_handler(u32 function, acpi_physical_address address,
> u32 bits, acpi_integer *value,
> void *handler_context, void *region_context)
> @@ -858,7 +844,7 @@ static int ec_install_handlers(struct acpi_ec *ec)
> status = acpi_install_address_space_handler(ec->handle,
> ACPI_ADR_SPACE_EC,
> &acpi_ec_space_handler,
> - &acpi_ec_space_setup, ec);
> + NULL, ec);
> if (ACPI_FAILURE(status)) {
> acpi_remove_gpe_handler(NULL, ec->gpe, &acpi_ec_gpe_handler);
> return -ENODEV;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2008-03-25 0:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 20:22 [PATCH 1/2] ACPI: EC: Use default setup handler Alexey Starikovskiy
2008-03-24 20:22 ` [PATCH 2/2] Don't delete boot ec Alexey Starikovskiy
2008-03-25 0:52 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803242052.51543.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=Linux-acpi@vger.kernel.org \
--cc=astarikovskiy@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.