From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Cluster Project branch, RHEL5, updated. cmirror_1_1_15-16-g55dca01
Date: 24 Mar 2008 21:21:18 -0000 [thread overview]
Message-ID: <20080324212118.1233.qmail@sourceware.org> (raw)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Cluster Project".
http://sources.redhat.com/git/gitweb.cgi?p=cluster.git;a=commitdiff;h=55dca012f902c090df399b2dc91cfa86d13f2e90
The branch, RHEL5 has been updated
via 55dca012f902c090df399b2dc91cfa86d13f2e90 (commit)
from c1f442a049bc5f7369ff5c88a834dab2e9b09251 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 55dca012f902c090df399b2dc91cfa86d13f2e90
Author: Joel Becker <joel.becker@oracle.com>
Date: Wed Mar 19 16:08:49 2008 -0500
libdlm: Don't pass LKF_WAIT to the kernel
libdlm is passing LKF_WAIT to the kernel. In the kernel, the unlock
path strictly audits flags, and errors on this unknown (to the kernel)
flag. The correct answer is to keep the flag in userspace.
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: David Teigland <teigland@redhat.com>
-----------------------------------------------------------------------
Summary of changes:
dlm/lib/libdlm.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dlm/lib/libdlm.c b/dlm/lib/libdlm.c
index 876c16e..0612d09 100644
--- a/dlm/lib/libdlm.c
+++ b/dlm/lib/libdlm.c
@@ -754,7 +754,7 @@ static int ls_lock_v5(dlm_lshandle_t ls,
req->cmd = DLM_USER_LOCK;
req->i.lock.mode = mode;
- req->i.lock.flags = flags;
+ req->i.lock.flags = (flags & ~LKF_WAIT);
req->i.lock.lkid = lksb->sb_lkid;
req->i.lock.parent = parent;
req->i.lock.lksb = lksb;
@@ -822,7 +822,7 @@ static int ls_lock_v6(dlm_lshandle_t ls,
req->cmd = DLM_USER_LOCK;
req->i.lock.mode = mode;
- req->i.lock.flags = flags;
+ req->i.lock.flags = (flags & ~LKF_WAIT);
req->i.lock.lkid = lksb->sb_lkid;
req->i.lock.parent = parent;
req->i.lock.lksb = lksb;
@@ -1014,7 +1014,7 @@ static int ls_unlock_v5(struct dlm_ls_info *lsinfo, uint32_t lkid,
set_version_v5(&req);
req.cmd = DLM_USER_UNLOCK;
req.i.lock.lkid = lkid;
- req.i.lock.flags = flags;
+ req.i.lock.flags = (flags & ~LKF_WAIT);
req.i.lock.lksb = lksb;
req.i.lock.castparam = astarg;
/* DLM_USER_UNLOCK will default to existing completion AST */
@@ -1036,7 +1036,7 @@ static int ls_unlock_v6(struct dlm_ls_info *lsinfo, uint32_t lkid,
req.cmd = DLM_USER_UNLOCK;
req.i.lock.namelen = 0;
req.i.lock.lkid = lkid;
- req.i.lock.flags = flags;
+ req.i.lock.flags = (flags & ~LKF_WAIT);
req.i.lock.lksb = lksb;
req.i.lock.castparam = astarg;
/* DLM_USER_UNLOCK will default to existing completion AST */
hooks/post-receive
--
Cluster Project
reply other threads:[~2008-03-24 21:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080324212118.1233.qmail@sourceware.org \
--to=teigland@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.